Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Getting branding assets from Eclipse Che Dashboard should not re… #1708

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix: Getting branding assets from Eclipse Che Dashboard should not re… #1708

merged 1 commit into from
Jun 15, 2023

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jun 15, 2023

…quire authentiction

What does this PR do?

Getting branding assets from Eclipse Che Dashboard should not require authentiction

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#22239

How to test this PR?

N/A

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

l0rd
l0rd approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested but at first glance LGTM

@openshift-ci openshift-ci bot added the lgtm label Jun 15, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: l0rd, tolusha

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tolusha
Copy link
Contributor Author

tolusha commented Jun 15, 2023

/retest

1 similar comment
@tolusha
Copy link
Contributor Author

tolusha commented Jun 15, 2023

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jun 15, 2023

@tolusha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v12-che-behind-proxy 328b144 link true /test v12-che-behind-proxy
ci/prow/v11-operator-test 328b144 link true /test v11-operator-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tolusha tolusha merged commit 94934bf into main Jun 15, 2023
@tolusha tolusha deleted the 22239 branch June 15, 2023 11:58
@devstudio-release
Copy link

Build 3.8 :: operator-bundle_3.x/1525: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: sync-to-downstream_3.x/3672: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: get-sources-rhpkg-container-build_3.x/3514: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: push-latest-container-to-quay_3.x/2693: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: copyIIBsToQuay/1496: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: get-sources-rhpkg-container-build_3.x/3514: SUCCESS

devspaces-operator-bundle : 3.x :: Build 53349458 : quay.io/devspaces/devspaces-operator-bundle:3.8-24
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/2693 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.8-21
- quay.io/devspaces/configbump-rhel8:3.8-3
- quay.io/devspaces/dashboard-rhel8:3.8-4
- quay.io/devspaces/devfileregistry-rhel8:3.8-9
- quay.io/devspaces/devspaces-rhel8-operator:3.8-6
- quay.io/devspaces/idea-rhel8:3.8-1
- quay.io/devspaces/pluginregistry-rhel8:3.8-3
- quay.io/devspaces/server-rhel8:3.8-6
- quay.io/devspaces/traefik-rhel8:3.8-5
- quay.io/devspaces/udi-rhel8:3.8-20
= registry.redhat.io/devworkspace/devworkspace-rhel8-operator:0.20-4
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.11.0-202306070816.p0.ga805ba5.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.11.0-202306070816.p0.gaad1b28.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.6-994

@devstudio-release
Copy link

Build 3.8 :: sync-to-downstream_3.x/3672: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3514 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.8 :: operator-bundle_3.x/1525: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3672 triggered

@devstudio-release
Copy link

Build 3.8 :: dsc_3.x/1032: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: copyIIBsToQuay/1496: SUCCESS

3.8
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.8-24
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.8-v4.13-517310-s390x
  + quay.io/devspaces/iib:3.8-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.8-v4.12-517300-s390x
  + quay.io/devspaces/iib:3.8-v4.11-517289-s390x
  + quay.io/devspaces/iib:3.8-v4.10-517285-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.8-v4.13-517310-ppc64le
  + quay.io/devspaces/iib:3.8-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.8-v4.12-517300-ppc64le
  + quay.io/devspaces/iib:3.8-v4.11-517289-ppc64le
  + quay.io/devspaces/iib:3.8-v4.10-517285-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.8-v4.13-517310-x86_64
  + quay.io/devspaces/iib:3.8-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.8-v4.12-517300-x86_64
  + quay.io/devspaces/iib:3.8-v4.11-517289-x86_64
  + quay.io/devspaces/iib:3.8-v4.10-517285-x86_64

@devstudio-release
Copy link

Build 3.8 :: dsc_3.x/1033: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: dsc_3.x/1033: SUCCESS

3.8.0 CI

@devstudio-release
Copy link

Build 3.8 :: operator_3.x/253: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: sync-to-downstream_3.x/3676: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: get-sources-rhpkg-container-build_3.x/3518: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: get-sources-rhpkg-container-build_3.x/3518: SUCCESS

devspaces-operator : 3.x :: Build 53388268 : quay.io/devspaces/devspaces-rhel8-operator:3.8-7
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/2695 triggered

@devstudio-release
Copy link

Build 3.8 :: operator_3.x/253: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3676 triggered

@devstudio-release
Copy link

Build 3.8 :: operator-bundle_3.x/1526: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: sync-to-downstream_3.x/3682: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: get-sources-rhpkg-container-build_3.x/3525: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: push-latest-container-to-quay_3.x/2704: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: copyIIBsToQuay/1497: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: get-sources-rhpkg-container-build_3.x/3525: SUCCESS

devspaces-operator-bundle : 3.x :: Build 53388913 : quay.io/devspaces/devspaces-operator-bundle:3.8-25
SUCCESS; copied to quay; /DS_CI/push-latest-container-to-quay_3.x/2704 triggered;
Bundle CSV related images:
- quay.io/devspaces/code-rhel8:3.8-21
- quay.io/devspaces/configbump-rhel8:3.8-4
- quay.io/devspaces/dashboard-rhel8:3.8-5
- quay.io/devspaces/devfileregistry-rhel8:3.8-10
- quay.io/devspaces/devspaces-rhel8-operator:3.8-7
- quay.io/devspaces/idea-rhel8:3.8-1
- quay.io/devspaces/pluginregistry-rhel8:3.8-4
- quay.io/devspaces/server-rhel8:3.8-7
- quay.io/devspaces/traefik-rhel8:3.8-6
- quay.io/devspaces/udi-rhel8:3.8-21
= registry.redhat.io/devworkspace/devworkspace-rhel8-operator:0.20-4
= registry.redhat.io/openshift4/ose-kube-rbac-proxy:v4.11.0-202306070816.p0.ga805ba5.assembly.stream
= registry.redhat.io/openshift4/ose-oauth-proxy:v4.11.0-202306070816.p0.gaad1b28.assembly.stream
= registry.redhat.io/rhscl/mongodb-36-rhel7:1-50
= registry.redhat.io/ubi8/ubi-minimal:8.6-994

@devstudio-release
Copy link

Build 3.8 :: sync-to-downstream_3.x/3682: SUCCESS

Build container: devspaces-operator-bundle synced; /DS_CI/get-sources-rhpkg-container-build_3.x/3525 triggered; /job/DS_CI/job/dsc_3.x triggered;

@devstudio-release
Copy link

Build 3.8 :: operator-bundle_3.x/1526: SUCCESS

Upstream sync done; /DS_CI/sync-to-downstream_3.x/3682 triggered

@devstudio-release
Copy link

Build 3.8 :: dsc_3.x/1034: Console, Changes, Git Data

@devstudio-release
Copy link

Build 3.8 :: dsc_3.x/1034: SUCCESS

3.8.0 CI

@devstudio-release
Copy link

Build 3.8 :: copyIIBsToQuay/1497: SUCCESS

3.8
arches = x86_64, s390x, ppc64le;
  * LATEST DS OPERATOR BUNDLE = <a href=https://quay.io/repository/devspaces/devspaces-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devspaces-operator-bundle:3.8-25
  * LATEST DWO OPERATOR BUNDLE = <a href=https://quay.io/repository/devworkspace/devworkspace-operator-bundle?tab=tags>registry-proxy.engineering.redhat.com/rh-osbs/devworkspace-operator-bundle:???
+ s390x-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.8-v4.13-519316-s390x
  + quay.io/devspaces/iib:3.8-v4.13-s390x
  + quay.io/devspaces/iib:next-v4.13-s390x
  + quay.io/devspaces/iib:3.8-v4.12-519959-s390x
  + quay.io/devspaces/iib:3.8-v4.12-s390x
  + quay.io/devspaces/iib:next-v4.12-s390x
  + quay.io/devspaces/iib:3.8-v4.11-519958-s390x
  + quay.io/devspaces/iib:3.8-v4.11-s390x
  + quay.io/devspaces/iib:next-v4.11-s390x
  + quay.io/devspaces/iib:3.8-v4.10-519957-s390x
  + quay.io/devspaces/iib:3.8-v4.10-s390x
  + quay.io/devspaces/iib:next-v4.10-s390x
+ ppc64le-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.8-v4.13-519316-ppc64le
  + quay.io/devspaces/iib:3.8-v4.13-ppc64le
  + quay.io/devspaces/iib:next-v4.13-ppc64le
  + quay.io/devspaces/iib:3.8-v4.12-519959-ppc64le
  + quay.io/devspaces/iib:3.8-v4.12-ppc64le
  + quay.io/devspaces/iib:next-v4.12-ppc64le
  + quay.io/devspaces/iib:3.8-v4.11-519958-ppc64le
  + quay.io/devspaces/iib:3.8-v4.11-ppc64le
  + quay.io/devspaces/iib:next-v4.11-ppc64le
  + quay.io/devspaces/iib:3.8-v4.10-519957-ppc64le
  + quay.io/devspaces/iib:3.8-v4.10-ppc64le
  + quay.io/devspaces/iib:next-v4.10-ppc64le
+ x86_64-rhel8 IIB(s) copied:
  + quay.io/devspaces/iib:3.8-v4.13-519316-x86_64
  + quay.io/devspaces/iib:3.8-v4.13-x86_64
  + quay.io/devspaces/iib:next-v4.13-x86_64
  + quay.io/devspaces/iib:3.8-v4.12-519959-x86_64
  + quay.io/devspaces/iib:3.8-v4.12-x86_64
  + quay.io/devspaces/iib:next-v4.12-x86_64
  + quay.io/devspaces/iib:3.8-v4.11-519958-x86_64
  + quay.io/devspaces/iib:3.8-v4.11-x86_64
  + quay.io/devspaces/iib:next-v4.11-x86_64
  + quay.io/devspaces/iib:3.8-v4.10-519957-x86_64
  + quay.io/devspaces/iib:3.8-v4.10-x86_64
  + quay.io/devspaces/iib:next-v4.10-x86_64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0rd l0rd l0rd approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt

@ibuziuk ibuziuk Awaiting requested review from ibuziuk ibuziuk is a code owner

Assignees

@l0rd l0rd

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tolusha @devstudio-release @l0rd