Provide redirect endpoints for JetBrains-based editors #1318
Conversation
vzhukovs
requested review from
vinokurig,
vitaliy-guliy,
benoitf and
svor
as code owners
|
Click here to review and test in web IDE: |
|
/retest |
|
@vzhukovs are you going to apply the same changes for Devspaces? |
che-editors.yaml
Outdated
| @@ -603,6 +603,27 @@ editors: | |||
| path: '/?backgroundColor=434343&wss' | |||
| secure: false | |||
| protocol: http | |||
| - name: code-redirect-1 | |||
There was a problem hiding this comment.
I think code-redirect was used for CheCode and theia-redirect for theia so maybe here it should be using intellij or idea-redirect
There was a problem hiding this comment.
Yeah, make sense, just didn't notice that fact, that theia has own naming for such endpoints. So, I'm going to update the naming, thanks for pointing on that!
Sure, I'll prepare the PR, but a bit later |
|
Click here to review and test in web IDE: |
vzhukovs
force-pushed
the
jetbrains-endpoints
branch
from
627f8ff to
0a97e26
Compare
|
Click here to review and test in web IDE: |
|
Updated endpoints naming to use |
|
@vzhukovs I still see code-* |
|
Click here to review and test in web IDE: |
Signed-off-by: Vladyslav Zhukovskyi <[email protected]>
vzhukovs
force-pushed
the
jetbrains-endpoints
branch
from
2a821c1 to
9001d83
Compare
|
Click here to review and test in web IDE: |
|
@benoitf not, it should be updated |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: benoitf, svor, vzhukovs The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@vzhukovs yep 👍 |
What does this PR do?
In favor of the incoming changes in JetBrains-based editors, made by che-incubator/jetbrains-editor-images#121 there is a need to add redirect ports, as it done for che-code and che-theia editors.
Signed-off-by: Vladyslav Zhukovskyi [email protected]
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
eclipse-che/che#21141
How to test this PR?
Open any sample from Devfile registry with the following factory link:
https://che-host/#https://repository/?che-editor=https://gist.githubusercontent.com/vzhukovs/95337765cbde9b6ed1f252e6e77671a2/raw/ce2508d6cd101d400a4b99cc788933ef5f7eff84/che-editor.yamland check that Endpoints panel contains
intellij-redirect-*portsPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.