chore: Remove some outdated PVC storage properties #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of eclipse-che/che#21405 The following che-server properties have been removed as PVC configuration in Eclipse Che is now managed by the devworkspace-operator: - che.workspace.projects.storage.default.size - che.infra.kubernetes.pvc.enabled - che.infra.kubernetes.pvc.strategy - che.infra.kubernetes.pvc.precreate_subpaths - che.infra.kubernetes.pvc.name - che.infra.kubernetes.pvc.storage_class_name - che.infra.kubernetes.pvc.quantity - che.infra.kubernetes.pvc.access_mode - che.infra.kubernetes.pvc.wait_bound - che.workspace.storage.available_types Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow
requested review from
ibuziuk,
nickboldt,
themr0c and
MichalMaler
as code owners
|
More work on this PR is likely needed to remove the associated Java classes related to these properties. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the following Che-Server properties, as PVC configuration in Eclipse Che is now managed by the devworkspace-operator:
Screenshot/screencast of this PR
n/a
What issues does this PR fix or reference?
Part of eclipse-che/che#21405
How to test this PR?
n/a
Additional notes:
.propertiesfile, or whether the PVC configuration code needs to be removed. Perhaps as a first step, removing the properties is sufficient.Additionally, there may be additional properties that can be removed as part of this PR, but I wasn't sure if they were still in use:
I imagine the maintenance PVC job in che-server is to cleanup a workspace off the common PVC when a workspace is deleted. If that's the case, then this functionality already exists in DWO, and these properties can also be removed.
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.