Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks are not ended properly #19821

Closed
4 of 12 tasks
svor opened this issue May 18, 2021 · 7 comments
Closed
4 of 12 tasks

Tasks are not ended properly #19821

svor opened this issue May 18, 2021 · 7 comments
Assignees
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Milestone

Comments

@svor
Copy link
Contributor

svor commented May 18, 2021

Describe the bug

When start a task from the My workspace view by quickly clicking many times on it, it is not ended properly (IDE doesn't show "✓", but still shows spinning wheel) and the next task execution can't be started.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Use this devfile to create a workspace:
apiVersion: 1.0.0
metadata:
  name: test-workspace
components:
  - mountSources: true
    memoryLimit: 512Mi
    type: dockerimage
    image: 'quay.io/eclipse/che-java11-maven:nightly'
    alias: maven
commands:
  - name: Click me many times
    actions:
      - type: exec
        command: echo 'Command was finished'
        component: maven
  1. Try to click quickly many times on Click me many times from Workspace view
  2. See that the task never finish and it is not possible to re-run it

Expected behavior

Task should be finished properly

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

vokoscreen-2021-08-02_16-04-15.mp4

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know
@svor svor added kind/bug Outline of a bug - must adhere to the bug report template. area/plugins severity/P2 Has a minor but important impact to the usage or development of the system. severity/P1 Has a major impact to usage or development of the system. and removed severity/P2 Has a minor but important impact to the usage or development of the system. labels May 18, 2021
@svor svor mentioned this issue Jul 27, 2021
34 tasks
@svor
Copy link
Contributor Author

svor commented Jul 28, 2021

downstream issue https://issues.redhat.com/browse/CRW-1782

@tsmaeder
Copy link
Contributor

tsmaeder commented Aug 2, 2021

So the issue is that we manage to create parallel instances of the same task, but we can never get rid of the second one and it doesn't get marked as finished?

@svor svor modified the milestones: 7.34, 7.35 Aug 11, 2021
@svor
Copy link
Contributor Author

svor commented Aug 12, 2021

eclipse-theia/theia#9858 should fix the problem

@nickboldt
Copy link
Contributor

given PR was merged and 7.35.0 is live, can we verify this is fixed?

@tsmaeder
Copy link
Contributor

The PR was merged this morning.

@nickboldt nickboldt modified the milestones: 7.35, 7.36 Aug 24, 2021
@svor svor mentioned this issue Sep 7, 2021
26 tasks
@svor svor removed the sprint/next label Sep 8, 2021
@nickboldt
Copy link
Contributor

PR merged, but label = sprint/next... so I'm guessing this slips to 7.37.

@nickboldt nickboldt modified the milestones: 7.36, 7.37 Sep 10, 2021
@svor
Copy link
Contributor Author

svor commented Sep 17, 2021

Currently blocked by: Align che-theia with upstream changes #20366

@svor svor mentioned this issue Sep 23, 2021
25 tasks
@svor svor modified the milestones: 7.37, 7.38 Sep 29, 2021
@svor svor closed this as completed Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. sprint/current
Projects
None yet
Development

No branches or pull requests

3 participants