Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation on nginx ingress leads to infinite redirect on dashboard #19914

Closed
4 tasks done
tarioch opened this issue Jun 2, 2021 · 2 comments
Closed
4 tasks done

Installation on nginx ingress leads to infinite redirect on dashboard #19914

tarioch opened this issue Jun 2, 2021 · 2 comments
Labels
area/dashboard area/install Issues related to installation, including offline/air gap and initial setup kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@tarioch
Copy link

tarioch commented Jun 2, 2021

Describe the bug

After installing on my cluster, the ingress that was generated for the dashboard looked like this

spec:
  rules:
  - host: che-eclipse-che.che.mydomain.com
    http:
      paths:
      - backend:
          service:
            name: che-dashboard
            port:
              number: 8080
        path: /dashboard/*
        pathType: ImplementationSpecific
  tls:
  - hosts:
    - che-eclipse-che.che.mydomain.com
    secretName: che-tls

When trying to access the dashboard, there was an infinite redirect to the dashboard.

After dropping the * at the end of /dashboard/, everything works fine.

Che version

7.32.0-SNAPSHOT
installed with chectl 7.31.0

Runtime

  • k3s Server Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.1+k3s1", GitCommit:"75dba57f9b1de3ec0403b148c52c348e1dee2a5e", GitTreeState:"clean", BuildDate:"2021-05-21T16:12:29Z", GoVersion:"go1.16.4", Compiler:"gc", Platform:"linux/amd64"}

Installation method

  • chectl
chectl server:deploy --installer=helm --platform=k8s --domain=che.mydomain.com --telemetry=off --multiuser
chectl/7.31.0 linux-x64 node-v12.22.1

Environment

  • my computer
    • Linux
@tarioch tarioch added the kind/bug Outline of a bug - must adhere to the bug report template. label Jun 2, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jun 2, 2021
@l0rd l0rd added area/dashboard area/install Issues related to installation, including offline/air gap and initial setup status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jun 2, 2021
@l0rd
Copy link
Contributor

l0rd commented Jun 2, 2021

cc @tolusha @sleshchenko

@sleshchenko
Copy link
Member

sleshchenko commented Jun 3, 2021

Thanks, @tolusha and @skabashnyuk for investigating the problem. Investigation result:
It stops working after #19542 (7.31.0) but actually these changes are not cause of failure, while the original failure cause is #18720.

Which basically mean - path are ingress controller implementation specific, for nginx it's / or /.* (if we enable regexp with the corresponding annotation). For GCP ingress controller it's /*.
The solution here could be:
In addition to the ability to configure ingress annotations, we also should ask users to configure value for * for a specific ingress controller. The default value should be nginx specific one.

@tolusha tolusha added sprint/current team/deploy severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach labels Jun 3, 2021
@tolusha tolusha added this to the 7.32 milestone Jun 7, 2021
@tolusha tolusha closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/install Issues related to installation, including offline/air gap and initial setup kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

5 participants