Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Expose dashboard ingress path #20

Merged
merged 1 commit into from
Jun 7, 2021
Merged

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Jun 3, 2021

Signed-off-by: Anatolii Bazko [email protected]

What does this PR do?

Expose dashboard ingress path. By default it is set to /dashboard'. To override a default value pls use --helm-patch-yamlflag withchectl`:

cat >patch.yaml<<EOF
> dashboard:
>   ingressPath: /dashboard/*
> EOF
chectl server:deploy --installer=helm < .... >  --helm-patch-yaml patch.yaml

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

eclipse-che/che#19914

How to test this PR?

  1. cd deploy/kubernetes/helm/che
  2. helm dependency update
  3. chectl server:deploy --installer=helm --platform=minikube --multiuser --templates ../../..
  4. chectl dashboard:open check if dashboard is opened in a browser

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha tolusha requested a review from nickboldt as a code owner June 3, 2021 09:43
@tolusha tolusha mentioned this pull request Jun 3, 2021
47 tasks
@tolusha
Copy link
Contributor Author

tolusha commented Jun 3, 2021

/cc @jasonbridges @PatNikB @degiple

@che-bot
Copy link
Contributor

che-bot commented Jun 3, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@skabashnyuk
Copy link
Contributor

@tolusha do we need to change something in our documentation?

@tolusha
Copy link
Contributor Author

tolusha commented Jun 4, 2021

@tolusha
Copy link
Contributor Author

tolusha commented Jun 4, 2021

@tolusha tolusha merged commit a4f454b into main Jun 7, 2021
@skabashnyuk skabashnyuk deleted the ab/exposedashboardingress branch June 7, 2021 07:06
@skabashnyuk skabashnyuk added this to the 7.32 milestone Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants