Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Che-Theia Activity Tracker extension to DevWorkspace mode #20460

Closed
sleshchenko opened this issue Sep 13, 2021 · 5 comments · Fixed by eclipse-che/che-theia#1239 or eclipse-che/che-plugin-registry#1077
Assignees
Labels
area/editor/theia Issues related to the che-theia IDE of Che engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Sep 13, 2021

Is your enhancement related to a problem? Please describe

Currently, DevWorkspaces are not idled by timeout.

Describe the solution you'd like

We agreed to cover that is currently working for workspaces powered by Che Server workspace engine. As it's relatively cheap to do. So, it's needed to adapt the activity Theia plugin to be run in DevWorkpsace mode, there is should report their activities to Che Machine Exec instead of Che Server. It's POST without body to /activity/tick API path
Screenshot_20210913_153252

Describe alternatives you've considered

The alternative is to handle that on Che level but not editor, but it's something we plan to do in #20345

Additional context

No response

@sleshchenko sleshchenko added kind/enhancement A feature request - must adhere to the feature request template. engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. area/plugins labels Sep 13, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 13, 2021
@benoitf benoitf added area/editor/theia Issues related to the che-theia IDE of Che and removed area/plugins labels Sep 13, 2021
@azatsarynnyy
Copy link
Member

Let me know once an endpoint on Machine Exec side is ready.

@Katka92 Katka92 added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 13, 2021
@sleshchenko
Copy link
Member Author

@azatsarynnyy It's already there

@azatsarynnyy
Copy link
Member

Thanks! We'll look at it next sprint.

@vzhukovs vzhukovs self-assigned this Sep 30, 2021
@azatsarynnyy azatsarynnyy added the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 1, 2021
@azatsarynnyy azatsarynnyy changed the title Adapt Theia Activity plugin for DevWorkspace mode Adapt Che-Theia Activity Tracker extension to DevWorkspace mode Oct 1, 2021
@azatsarynnyy azatsarynnyy mentioned this issue Oct 19, 2021
3 tasks
@azatsarynnyy
Copy link
Member

@vzhukovs could you give a brief update on the state of the work - what has been done and what problems still need to be solved?

@vzhukovs
Copy link
Contributor

@azatsarynnyy sure. The code for implementing http requests has been written and correct endpoint has been obtained. But on minikube with dev workspace mode enabled there is a problem with sending request to machine exec. It seems, that there is something wrong with the certificates or with forming certificate bundle. This is the last thing that left. Investigating how to workaround it.

@azatsarynnyy azatsarynnyy removed sprint/current status/in-progress This issue has been taken by an engineer and is under active development. labels Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editor/theia Issues related to the che-theia IDE of Che engine/devworkspace Issues related to Che configured to use the devworkspace controller as workspace engine. kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
6 participants