Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Implement activity tracking for k8s #1239

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Implement activity tracking for k8s #1239

merged 1 commit into from
Nov 2, 2021

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Oct 27, 2021

What does this PR do?

Implement activity tracking mechanism for DevWorkspace environment.

Signed-off-by: Vladyslav Zhukovskyi [email protected]

Screenshot/screencast of this PR

Screenshot provided in How to test section.

What issues does this PR fix or reference?

fixes eclipse-che/che#20460

How to test this PR?

Create the workspace from the following repository: https://github.com/vzhukovs/che-editor-test2
Open minikube dashboard and go to machine-exec logs, there should be tick events:
Снимок экрана 2021-10-28 в 12 00 20

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Vladyslav Zhukovskyi <[email protected]>
@codecov
Copy link

codecov bot commented Oct 27, 2021

Codecov Report

Merging #1239 (3bd071d) into main (c299f59) will decrease coverage by 0.10%.
The diff coverage is 25.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1239      +/-   ##
==========================================
- Coverage   32.78%   32.67%   -0.11%     
==========================================
  Files         290      296       +6     
  Lines        9885     9872      -13     
  Branches     1457     1327     -130     
==========================================
- Hits         3241     3226      -15     
- Misses       6641     6642       +1     
- Partials        3        4       +1     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <0.00%> (ø)
...credentials/src/browser/che-credentials-service.ts 0.00% <0.00%> (ø)
...entials/src/browser/credentials-frontend-module.ts 0.00% <0.00%> (ø)
...eia-credentials/src/common/credentials-protocol.ts 0.00% <0.00%> (ø)
...eia-credentials/src/node/che-credentials-server.ts 0.00% <0.00%> (ø)
...s/src/node/che-theia-credentials-backend-module.ts 0.00% <0.00%> (ø)
...rowser/src/browser/che-mini-browser-environment.ts 0.00% <0.00%> (ø)
...ia-plugin-remote/src/node/hosted-plugin-service.ts 0.00% <0.00%> (ø)
...in-remote/src/node/plugin-remote-backend-module.ts 0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts 0.00% <0.00%> (ø)
... and 212 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85b346...3bd071d. Read the comment docs.

@che-bot
Copy link
Contributor

che-bot commented Oct 27, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1239
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1239

Test product:

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

@vzhukovs vzhukovs self-assigned this Oct 28, 2021
@vzhukovs vzhukovs added kind/enhancement New feature or request severity/P1 labels Oct 28, 2021
@vzhukovs vzhukovs marked this pull request as ready for review October 28, 2021 09:02
@benoitf
Copy link
Contributor

benoitf commented Oct 28, 2021

@vzhukovs shouldn't it include as well a PR on plugin registry side to enable the shutdown of workspace by machine-exec ?

@vzhukovs
Copy link
Contributor Author

@vzhukovs shouldn't it include as well a PR on plugin registry side to enable the shutdown of workspace by machine-exec ?

Do you mean to provide CHE_WORKSPACE_IDLE_TIMEOUT env variable to the default editors?

@vzhukovs vzhukovs merged commit cf11b14 into main Nov 2, 2021
@vzhukovs vzhukovs deleted the activity branch November 2, 2021 09:56
@che-bot che-bot added this to the 7.39 milestone Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request severity/P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt Che-Theia Activity Tracker extension to DevWorkspace mode
4 participants