Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of improvements in deployment from GF8 concurrency branch #24962

Merged
merged 34 commits into from
Jun 5, 2024

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented May 24, 2024

Backported some cleanups from #24954 + much more rather small cleanups because originally it did not pass QL tests and I spent whole week investigating why it always breaks with every small change until I reached this safepoint.

  • Added preInvoke before executing CDI extensions in WeldDeployer - some extensions need it.
  • Added logging of ignored empty elements in SaxParserHandler
  • Fixed few typos
  • DeploymentException is now a standard exception - serialization of stacktraces was revisited in Java 9, so I expect that this is ok.
  • RestExtension class was deleted, it is not required any more.
  • ACLSingletonProvider - cleanup, revided comments, using ConcurrentHashMap instead of Hashtable
  • Fixed NPE in EventListener (noticed once in logs)
  • ComponentInvocation now has toString
  • Added logs to WeldDeployer, - especially events are interesting
  • CommonClassLoaderServiceImpl - removed attempts to load Derby from JDK (was possible in JDK6 which we don't support any more for a while)
  • Replaced many @Context annotations with @Inject

Note

  • Disable whitespaces when reviewing, it will be more readable

@dmatej dmatej added the enhancement New feature or request label May 24, 2024
@dmatej dmatej added this to the 7.0.15 milestone May 24, 2024
@dmatej dmatej self-assigned this May 24, 2024
@dmatej dmatej force-pushed the welddeployer branch 5 times, most recently from 9d9cd2c to 3a095c7 Compare May 28, 2024 16:46
@arjantijms arjantijms modified the milestones: 7.0.15, 7.0.16 May 29, 2024
dmatej added 19 commits June 2, 2024 12:03
- Useful in logs

Signed-off-by: David Matějček <[email protected]>
- Using single lookup of InjectionManager
- The archiveFactory is private
- Removed dead try-finally
- Added space to failure messages.

Signed-off-by: David Matějček <[email protected]>
- The original code was probably required for some very old Java
- I this would cause some issues, just revert it.

Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
dmatej added 2 commits June 2, 2024 12:03
- In recent merge I moved wrong curly brace when resolving conflicts

Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej marked this pull request as ready for review June 2, 2024 12:55
@dmatej
Copy link
Contributor Author

dmatej commented Jun 2, 2024

Don't merge it yet, I will yet need to extend the preInvoke-postInvoke range - I rebased the #24954 to this locally and it failed few tests with qualifiers which was possible to fix just by this change. However I still need to find out how large range is required.

dmatej added 2 commits June 3, 2024 12:34
- Tested on GF8 where it is required for use of classifiers in Concurrency TCK

Signed-off-by: David Matějček <[email protected]>
- Split processing events - long method with parts with clear borders.
- Logging enabling/disabling CDI
- ModuleInfo.toString usable in logs

Signed-off-by: David Matějček <[email protected]>
dmatej added 3 commits June 4, 2024 14:37
- Because event() reacts on three kinds of events it appeared three times

Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
@arjantijms arjantijms requested review from pzygielo and avpinchuk June 4, 2024 16:07
@dmatej dmatej requested a review from avpinchuk June 4, 2024 22:04
@arjantijms arjantijms merged commit b4525f9 into eclipse-ee4j:master Jun 5, 2024
2 checks passed
@dmatej dmatej deleted the welddeployer branch June 5, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleaning enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants