-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of improvements in deployment from GF8 concurrency branch #24962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d9cd2c
to
3a095c7
Compare
- Useful in logs Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- Using single lookup of InjectionManager - The archiveFactory is private - Removed dead try-finally - Added space to failure messages. Signed-off-by: David Matějček <[email protected]>
- The original code was probably required for some very old Java - I this would cause some issues, just revert it. Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- In recent merge I moved wrong curly brace when resolving conflicts Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
pzygielo
reviewed
Jun 2, 2024
appserver/web/weld-integration/src/main/java/org/glassfish/weld/ACLSingletonProvider.java
Show resolved
Hide resolved
Don't merge it yet, I will yet need to extend the preInvoke-postInvoke range - I rebased the #24954 to this locally and it failed few tests with qualifiers which was possible to fix just by this change. However I still need to find out how large range is required. |
- Tested on GF8 where it is required for use of classifiers in Concurrency TCK Signed-off-by: David Matějček <[email protected]>
- Split processing events - long method with parts with clear borders. - Logging enabling/disabling CDI - ModuleInfo.toString usable in logs Signed-off-by: David Matějček <[email protected]>
avpinchuk
reviewed
Jun 3, 2024
appserver/deployment/dol/src/main/java/com/sun/enterprise/deployment/util/DOLUtils.java
Outdated
Show resolved
Hide resolved
- Because event() reacts on three kinds of events it appeared three times Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
arjantijms
approved these changes
Jun 4, 2024
Signed-off-by: David Matějček <[email protected]>
avpinchuk
requested changes
Jun 4, 2024
nucleus/common/internal-api/src/main/java/org/glassfish/internal/data/ApplicationInfo.java
Outdated
Show resolved
Hide resolved
Signed-off-by: David Matějček <[email protected]>
avpinchuk
approved these changes
Jun 4, 2024
hs536
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported some cleanups from #24954 + much more rather small cleanups because originally it did not pass QL tests and I spent whole week investigating why it always breaks with every small change until I reached this safepoint.
@Context
annotations with@Inject
Note