Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced method call incompatible with Java 11 #25022

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Replaced method call incompatible with Java 11 #25022

merged 1 commit into from
Jul 4, 2024

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Jul 4, 2024

@dmatej dmatej added the bug Something isn't working label Jul 4, 2024
@dmatej dmatej added this to the 7.0.16 milestone Jul 4, 2024
@dmatej dmatej requested review from arjantijms and avpinchuk July 4, 2024 15:27
@dmatej dmatej self-assigned this Jul 4, 2024
arjantijms
arjantijms approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we also have a com.sun.enterprise.util.Utility class with various isEmpty() methods, where you could add a method for the buffer?

@dmatej
Copy link
Contributor Author

dmatej commented Jul 4, 2024

Note that we also have a com.sun.enterprise.util.Utility class with various isEmpty() methods, where you could add a method for the buffer?

We can get rid of it in GF8. Or we can use StringUtils from commons-lang3. That Utility class is full of black magic :-)

@dmatej dmatej merged commit 1d3efd3 into eclipse-ee4j:master Jul 4, 2024
2 checks passed
@dmatej dmatej deleted the jdk17incompat branch July 4, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

@avpinchuk avpinchuk avpinchuk approved these changes

Assignees

@dmatej dmatej

Labels
bug Something isn't working
Projects
None yet
Milestone
7.0.16
Development

Successfully merging this pull request may close these issues.

Asadmin commands fail
3 participants
@dmatej @arjantijms @avpinchuk