Refactoring in security (TLS) #25056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmatej
force-pushed
the
tls
branch
4 times, most recently
from
252d005 to
0756c8a
Compare
- It was referred just from two other constants which had to have the dependency on deployment-common - JWS will be removed soon OR replaced by the Open Web Start Signed-off-by: David Matějček <[email protected]>
- the sleep can be interrupted - reproduced randomly on local machine - shortened sleep time to 100 ms Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- Added missing logs (when some class was not available, it did not even log it) - Removed e.printstacktrace when we already have logging or throw - Added missing exception cause Signed-off-by: David Matějček <[email protected]>
- When I broke some classes critical for startup, this was throwing NPE too Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- import order, wildchar imports removed - final fields - redundant modifiers, fixed order - improved braces - improved generics - habitat renamed to locator - using foreach were possible - throwing exceptions with causes Signed-off-by: David Matějček <[email protected]>
- Now it is injectable - Simplified initialization of related classes Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
- SSLImplementation is an interface and HK2 Contract, GlassfishSSLImpl
implements it
- SecurityRoleMapperFactoryGen moved to core-ee where is the only usage of it
- SSLConfigurator - lookup removed; in all cases I have seen now works the
locator variant, but I left the class loader variant here for now.
- JSSEImplementation was used just in tests
-> moved there as JSSEImplementation4Tests
- SecureAdminConfigUpgrade - the comment was not true any more
- GlassfishServerSocketFactory now always uses locator
Signed-off-by: David Matějček <[email protected]>
- Changes based on directly used packages in the module - I will do that with maven plugin later again. Signed-off-by: David Matějček <[email protected]>
avpinchuk
reviewed
Jul 21, 2024
nucleus/grizzly/config/src/main/java/org/glassfish/grizzly/config/ssl/JSSE14Support.java
Show resolved
Hide resolved
avpinchuk
approved these changes
Jul 22, 2024
pzygielo
reviewed
Jul 22, 2024
...ommon/common-util/src/test/java/com/sun/enterprise/universal/process/ProcessManagerTest.java
Outdated
Show resolved
Hide resolved
arjantijms
reviewed
Jul 22, 2024
| @@ -45,7 +46,7 @@ | |||
| public class SecureRMIServerSocketFactory extends SslRMIServerSocketFactory { | |||
|
|
|||
| private final InetAddress mAddress; | |||
| private final ServiceLocator habitat; | |||
| private final ServiceLocator locator; | |||
There was a problem hiding this comment.
Absolutely tiny remark, and no need to change it, but I think "serviceLocator" as variable name would be more clear (various other locations use that too)
There was a problem hiding this comment.
We use both, I prefer shorter version as it is clear in the context what it is.
Signed-off-by: David Matějček <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Contract, inaccessible classes in a context)@Contractwas the cause of all that original boilerplate codeReview