Refactored SharedSecureRandom #25113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Aug 25, 2024
•
dmatej
commented
- Removed fake inheritance
- Removed static "get"
- Removed unused SecurityUtils (used own SecureRandom, but it is related)
- Added log
- Note: I would prefer INFO, however that would spam some asadmin commands which don't differ between STDOUT and STDERR.
- Reported by SpotBugs plugin security extension locally (future PR in progress)
…leted Signed-off-by: David Matějček <[email protected]>
…ect. - SpotBugs security extension did not like it. - It wasn't a problem except readability. The get() was redundant. Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
Signed-off-by: David Matějček <[email protected]>
avpinchuk
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.