Fix exception if GF Embedded config file is set without schema #25151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OndroMih
force-pushed
the
ondromih-fix-config-file
branch
from
a7080c9 to
5e50669
Compare
Instead of logging a messsage like NCLS-CFGAPI-00086, it now logs a message like "Instance server from environment not found in domain.xml"
dmatej
approved these changes
Sep 23, 2024
avpinchuk
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlassFish Embedded expects that the
URIargument toglassFishProperties.setConfigFileURI()is "absolute", which means it should start with schema, e.g. "file:/glassfish/domain.xml". Otherwise it will throw an exception. This is counterintuitive.This fixes it to accept also a path without the schema, and retrieves the
URIfromFile. Then it's enough to pass "/glassfish/domain.xml", or a relative path, "domain.xml", for example.Also fixes a log message if domain.xml is not valid.