Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter for "terse" to Asadmin used in tests #25171

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Oct 7, 2024

It follows usual scenarios:

  • Usually we process the output by a software, most often we just need to know if it succeeded (which is signaled by the exit code 0), so there is no need to parse the Command succeeded message.
  • But sometimes we do exactly opposite.
  • Both ways usually differ by test class, sometimes by a test method.

The second change is about creating a backup of domain properties set by asadmin set and retrievable by asadmin get. (they can be manipulated also by other commands, like create-jdbc-pool, etc).

@OndroMih recently created this feature, this PR brings refactored and simplified version using the terse output and minimalistic api.

dmatej added 2 commits October 8, 2024 09:41
- because in most cases we process results programatically, but sometimes we
  parse human readable output too.

Signed-off-by: David Matějček <[email protected]>
@dmatej dmatej merged commit c30ecb4 into eclipse-ee4j:master Oct 8, 2024
2 checks passed
@dmatej dmatej deleted the terse branch October 8, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants