Fix embedded faces init #25287
Merged
Fix embedded faces init #25287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjantijms
requested review from
dmatej,
OndroMih,
russgold,
aubi,
hs536 and
avpinchuk
OndroMih
reviewed
Dec 15, 2024
appserver/web/web-glue/src/main/java/com/sun/enterprise/web/WebModuleListener.java
Outdated
Show resolved
Hide resolved
pzygielo
reviewed
Dec 16, 2024
appserver/web/web-glue/src/main/java/com/sun/enterprise/web/WebModule.java
Outdated
Show resolved
Hide resolved
OndroMih
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Faces applications fail to init when using embedded, since the service locator for setting the invocation does not match the one inside the servlet context for Faces apps to use, but only when using embedded.
A fix for now is to set the different service locator only for system apps (it is an app scoped locator, only really necessary for the admin ui).