Namespaces on inline HTML tags causes the component tree to be malformed

[ren-zhijun-oracle]

If we have a fragment like

<h:body>
  <c:if ...>
    <p xmlns="http://www.w3.org/1999/xhtml">Some text</p>
  </c:if>
  <h:button ... />
</h:body>

(The tags and namespace do not matter - so long as an HTML tag with a namespace declaration exists on the page, this error will occur)

The expected tree should have a structure like:

h:body
+ c:if
  - p
+ h:button

Instead it has a structure like:

h:body
+ c:if
  - p
  - h:button

[ren-zhijun-oracle]

@BalusC Commented
Reproduced.

[ren-zhijun-oracle]

@Toberumono Commented
I just realized that the pull request I made to fix this isn't listed here. It's #4282.

[ren-zhijun-oracle]

@edburns Commented
Please see this important message regarding community contributions to
Mojarra.

https://javaee.groups.io/g/jsf-spec/message/30

Also, please consider joining that group, as that group has taken the
place of the old [email protected] mailing list.

Thanks,

Ed Burns

[ren-zhijun-oracle]

@dmschlot Commented
Great to see there is a pull request already to fix this. This is a large bug for us and causing me to run a forked version of JSF.

All my HTML is valid XML, and XML serializers do not always allow you to control where namespaces are added. Inline SVGs are common enough that I feel it is a pretty good example of why this should be fixed. (Searching Google you'll find half the examples out there have xmlns on the inline svg.)

@BalusC Are you able to accept his pull request? If not who should I message?

[ren-zhijun-oracle]

• Issue Imported From: https://github.com/javaserverfaces/mojarra/issues/4281
• Original Issue Raised By:@Toberumono
• Original Issue Assigned To: Unassigned

[Toberumono]

The issue does not appear to have been fixed, and I cannot find an equivalent PR for the one that I made in the old repository (https://github.com/javaserverfaces/mojarra/pull/4282). Is there something that I need to or can do in order for my proposed fix to be included in the new repository?

[EvanKnowles]

Any progress on this? Accidentally reproduced this one again today.

[Toberumono]

@EvanKnowles Unfortunately, my PR has been completely ignored since I provided it. Also, it appears that same PR was lost when the repository was transferred.
I don't have time to recreate the PR, but the relevant file should not have significantly changed. If you are comfortable running a fork, all of the changes you need are here: Toberumono/mojarra@8a1e001
Edit: The code has changed slightly. The change needs to be made 39 lines earlier in the file (starting on line 300).

[EvanKnowles]

@Toberumono No chance of running a fork this side unfortunately, thanks for the info though.

[mnriem]

Relabeling as 2.3 as folks are saying it is an issue in 2.3 releases as well. Note that attaching a reproducer using only Mojarra will make it easier for the maintainers to address the issue.

[BalusC]

Still reproducible in 2.3.17. The long lost PR is here: javaee/mojarra#4282

[BalusC]

I've verified that the original fix is working. I'll run the entire 2.3 test set first before prepping a new PR.

[Toberumono]

The same issue applies to JSF 3.0 as well. Should I make a new PR or will this also get merged into JSF 3.x? The fix is identical for 3.x, if that helps.

[BalusC]

I'll upmerge, no worries. The entire 2.3 test set has passed, so I'll prep PR.

[Toberumono]

Actually, I have another PR from the old repository. I'm not sure if it was ever considered - it might count as a new feature.
It's this one: javaee/mojarra#4275

[melloware]

Just an FYI this fix broke a scenario in #5140