Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports #5111

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Remove unused imports #5111

merged 1 commit into from
Jun 24, 2022

Conversation

Emkas
Copy link
Contributor

@Emkas Emkas commented Jun 14, 2022

I've cleaned this type of warnings after importing project to Eclipse.

This is my first pull request in this project, so it more like exploring new ground.

@arjantijms
Copy link
Contributor

Thanks a lot for your contribution! One thing that we need in order to accept it, is for you to accept the so-called ECA. This means creating an Eclipse account with the same email used for committing at https://www.eclipse.org, and from your profile page accepting the ECA.

@Emkas
Copy link
Contributor Author

Emkas commented Jun 14, 2022

Hmmm... I've changed an e-mail in this commit and register on eclipse.org with the same e-mail address. Yet, I cannot accept ECA:

Could not validate the users ECA sign-off status. Please ensure that the e-mail address of all contributing accounts match a valid Eclipse Foundation account with a valid ECA.

But an e-mail looks good: emilsierzega [at] gmail

@melloware
Copy link
Contributor

I had a similar issue when I started with Mojarra and if I remember I had to update my commit with a signature after I signed the ECA. I will try and find the command someone had me run

@melloware
Copy link
Contributor

Here it is. I had to watch this video to fix mine

https://www.youtube.com/watch?v=YdJyJpT7rrs

Signed-off-by: Emil Sierżęga <[email protected]>
@Emkas
Copy link
Contributor Author

Emkas commented Jun 15, 2022

I had a similar issue when I started with Mojarra and if I remember I had to update my commit with a signature after I signed the ECA. I will try and find the command someone had me run

Thanks for the tip!

It's OK now. My fault that I didn't read CONTRIBUTING more carefully :-)

@BalusC BalusC merged commit 5cf4f59 into eclipse-ee4j:master Jun 24, 2022
@Emkas Emkas deleted the unused-imports branch June 24, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants