Stop using Boolean constructors #5123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Emil Sierżęga <[email protected]>
melloware
approved these changes
Jun 20, 2022
|
please approve all these cleaning/improving PRs I'm doing a similar work on other classes |
|
@pizzi80 wow, good to know! In one of PR I wrote that I corrected nearly half of warnings in this project, but I'm also waiting for approval in several of them so I can push another. But since you've wrote, I'll try to push it without waiting. It we'll be out waste of time if we would do the same job 😀 On Monday I'll look into your changes and I will stop doing mine for now. |
|
Now I'm mainly working on faces.js ... in meantime I'll resist from change Java files 😃 so with some luck We should not be in conflict 👯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ValueHolderTestCaseBase.