Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5262] Do not set the response buffer size if set to -1. #5263

Merged
merged 1 commit into from
Jul 1, 2023
Merged

[5262] Do not set the response buffer size if set to -1. #5263

merged 1 commit into from
Jul 1, 2023

Conversation

jamezp
Copy link
Contributor

@jamezp jamezp commented Jun 22, 2023

resolves #5262

@jamezp
Copy link
Contributor Author

jamezp commented Jun 22, 2023

I've still got one failing TCK with this change in WildFly. I'll make it a PR once I figure that out.

@jamezp jamezp marked this pull request as ready for review June 22, 2023 15:59
@jamezp jamezp mentioned this pull request Jun 22, 2023
Merged
@BalusC BalusC merged commit 7d96f03 into eclipse-ee4j:master Jul 1, 2023
@arjantijms arjantijms added the 5.0 label Jul 6, 2023
@BalusC
Copy link
Contributor

BalusC commented Jul 16, 2023 •
edited
Loading

Hmm this was already added to 4.0.x #5268 and should just be upmerged to master. I think 5.0 label is not correct here, @arjantijms ?

@BalusC BalusC removed the 5.0 label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not honoring value of -1 for the jakarta.faces.FACELETS_BUFFER_SIZE application parameter
3 participants
@jamezp @BalusC @arjantijms