Add rowStatePreserved property to UIRepeat, exactly the same as UIData #5349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a helper class so UIRepeat can also utilize them jakartaee/faces#1263
getter/setter as UIRepeat is going to be moved into API of Faces.next jakartaee/faces#1263
mnriem
reviewed
Nov 6, 2023
| @@ -16,6 +16,11 @@ | |||
|
|
|||
| package jakarta.faces.component; | |||
|
|
|||
| import static com.sun.faces.facelets.tag.faces.ComponentSupport.restoreFullDescendantComponentDeltaStates; | |||
There was a problem hiding this comment.
This won't work for 5.0 as UIData won't have access to com.sun.faces packages
There was a problem hiding this comment.
I suggest you move the necessary code into a private Utils class (or reuse one of the existing ones if possible) in the jakarta.faces.component package.
mnriem
requested changes
Nov 6, 2023
|
Already took into account this while approving your PR :) |
mnriem
approved these changes
Nov 11, 2023
BalusC
added a commit
that referenced
this pull request
Nov 11, 2023
BalusC
deleted the
faces_issue_1263_add_rowStatePreserved_to_UIRepeat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jakartaee/faces#1263
cc: @tandraschko