Fix for 'ordered comparison of pointer with integer zero' error on GCC 11.3. #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
pzygielo
reviewed
Nov 11, 2022
pzygielo
requested changes
Nov 11, 2022
|
I added what I believe is the EF (c) message you requested. Took it from a file in the Glassfish project. |
|
Thanks for the fix. |
pzygielo
approved these changes
Nov 14, 2022
|
Thanks. It was a pleasure to contribute, even with such a small change. |
|
December 1st is the target date of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one-liner fixes an
ordered comparison of pointer with integer zeroerror when compiling thecclientwith GCC 11.3.GCC 11.3 is the default version of GCC that is installed on Ubuntu 22.04.
Versions of GCC newer than 11.3 should also trigger the error.
The fix is backward compatible, having been tested with GCC 9.3.0 as well.