Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make entities immutable and create proper update methods that state by signature what can be updated. #342

Merged
merged 23 commits into from
Nov 17, 2016

Conversation

kaizimmerm
Copy link
Contributor

@kaizimmerm kaizimmerm commented Nov 9, 2016

Another task from #197

Entities are now immutable (setters removed) Entity Update/Create builders ensure that only supported fields can be changed/set.

DSL create entity Example:

entityFactory.distributionSet().create().name("name").version("version")
                .description("desc").type(123L).modules(modules)
                .requiredMigrationStep(true);

As part of the refactoring I also migrated more test data generation into the central test data factory.

The new builders add code overhead of course. I played around with Lombok but I think the introduction of that one should be discussed independent of this pull request.

definition what can be updated.

Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
Signed-off-by: kaizimmerm <[email protected]>
@kaizimmerm kaizimmerm merged commit ca63106 into eclipse-hawkbit:master Nov 17, 2016
@kaizimmerm kaizimmerm deleted the fix_repo_update_methods branch November 17, 2016 19:07
@kaizimmerm kaizimmerm modified the milestone: 0.2.0M3 Apr 3, 2017
AmmarBikic pushed a commit to bosch-io/hawkbit that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant