Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make interactivity optional for mocks #102

Merged
merged 9 commits into from
Jan 4, 2024
Merged

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Jan 4, 2024

This PR makes interactivity optional for the mock services, with the default being no interactivity. This addresses an issue when using these services in a container.

Copy link
Contributor

github-actions bot commented Jan 4, 2024

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

@wilyle wilyle self-assigned this Jan 4, 2024
@wilyle wilyle linked an issue Jan 4, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.

common/src/cmd_utils.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wilyle wilyle merged commit a3eaebf into main Jan 4, 2024
12 checks passed
@wilyle wilyle deleted the wilyle/interactive-mocks branch January 4, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Mock services have high CPU consumption in containers
2 participants