Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README numbering fix and resolve a security alert #64

Merged
merged 1 commit into from
Oct 18, 2023
Merged

README numbering fix and resolve a security alert #64

merged 1 commit into from
Oct 18, 2023

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Oct 18, 2023

  • Fixes the main README formatting which was resulting in incorrect numbering on the steps
  • Resolve one of the security alerts in the repo

@github-actions
Copy link
Contributor

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

ashbeitz
ashbeitz approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved,

@wilyle
Copy link
Contributor Author

wilyle commented Oct 18, 2023

markdown-link-check is having some instabilities and intermittently fails with external (e.g. aka.ms) links. Multiple runs have yielded different results, all marking valid links as invalid with a status of 0. I've manually verified that the links are working so this PR is good to go, but further investigation is needed to figure out why this happening and what we should do about it. One possible workaround is to allow 0 as a valid status code since that seems to be the symptom of this problem

@wilyle wilyle merged commit 4f10607 into main Oct 18, 2023
@wilyle wilyle deleted the wilyle/cleanup branch October 18, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorchiu jorchiu jorchiu approved these changes

@ashbeitz ashbeitz ashbeitz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wilyle @ashbeitz @jorchiu