Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT Integration #82

Merged
merged 11 commits into from
Nov 14, 2023
Merged

MQTT Integration #82

merged 11 commits into from
Nov 14, 2023

Conversation

wilyle
Copy link
Contributor

@wilyle wilyle commented Nov 13, 2023

Integrates Freyja with the MQTT protocol as used in the property and managed subscriber samples in Ibeji. Also includes the following infrastructure changes to facilitate this integration:

  • Add context field to entity contract
  • Changed proxies to use a "start" model instead of a "run" model
  • Moved proxy factory registration into a function that's called in the main setup

Copy link
Contributor

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

devkelley
devkelley previously approved these changes Nov 14, 2023
ashbeitz
ashbeitz previously approved these changes Nov 14, 2023
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments.

jorchiu
jorchiu previously approved these changes Nov 14, 2023
@wilyle wilyle dismissed stale reviews from jorchiu, ashbeitz, and devkelley via 8cefce7 November 14, 2023 19:39
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@wilyle wilyle merged commit 48df1d0 into main Nov 14, 2023
11 checks passed
@wilyle wilyle deleted the wilyle/mqtt branch November 14, 2023 21:30
@wilyle wilyle linked an issue Jan 4, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] Support MQTT Protocol with Providers
4 participants