fix : Remove assertExpose() from ServiceAssertion
#139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
rohanKanojia
force-pushed
the
pr/remove-exposed
branch
from
5df04a8
to
4a66469
Compare
manusa
force-pushed
the
pr/remove-exposed
branch
from
4a66469
to
dd4105c
Compare
manusa
approved these changes
Aug 4, 2022
Now that we're removing ExposeEnricher, there is no need to verify whether generated Service contains `expose: true` label. Signed-off-by: Rohan Kumar <[email protected]>
manusa
force-pushed
the
pr/remove-exposed
branch
from
dd4105c
to
baaa379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're removing ExposeEnricher, there is no need to verify
whether generated Service contains
expose: truelabel.Related to eclipse-jkube/jkube#1447
Signed-off-by: Rohan Kumar [email protected]