fix: internal-microservice profile prevents Service exposure

Signed-off-by: Marc Nuri <[email protected]>
eclipse-jkube · May 24, 2023 · 80746cc · 80746cc
1 parent 8d146ca
commit 80746cc
Show file tree

Hide file tree

Showing 7 changed files with 15 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -25,6 +25,7 @@ Usage:
 * Fix #2150: Bump Kubernetes Client to 6.6.0 (fixes issues when trace-logging OpenShift builds)
 * Fix #2162: Bump Kubernetes Client to 6.6.1 (HttpClient with support for PUT + InputStream)
 * Fix #2166: Potential command line injection in SpringBootWatcher
+* Fix #2170: `internal-microservice` profile prevents Service exposure
 
 ### 1.12.0 (2023-04-03)
 * Fix #1179: Move storageClass related functionality out of VolumePermissionEnricher to PersistentVolumeClaimStorageClassEnricher

diff --git a/gradle-plugin/doc/src/main/asciidoc/inc/_profiles.adoc b/gradle-plugin/doc/src/main/asciidoc/inc/_profiles.adoc
@@ -198,7 +198,7 @@ This plugin comes with a list of the following predefined profiles:
 | Includes no generators and only the <<jkube-dependency,jkube-dependency>> enricher for picking up and combining resources from the compile time dependencies.
 
 | *internal-microservice*
-| Do not expose a port for the service to generate. Otherwise the same as the _default_ profile.
+|  _default_ profile extension that prevents services from being externally exposed.
 
 | *osio*
 | Includes everything in the _default_ profile, plus additional enrichers and generators relevant only to https://openshift.io[OpenShift.io].

diff --git a/gradle-plugin/kubernetes/src/main/resources/META-INF/jkube/profiles-default.yml b/gradle-plugin/kubernetes/src/main/resources/META-INF/jkube/profiles-default.yml
@@ -154,4 +154,6 @@
   generator:
     excludes: []
   enricher:
-    excludes: []
+    excludes:
+      - jkube-ingress
+      - jkube-openshift-route
diff --git a/gradle-plugin/openshift/src/main/resources/META-INF/jkube/profiles-default.yml b/gradle-plugin/openshift/src/main/resources/META-INF/jkube/profiles-default.yml
@@ -149,4 +149,6 @@
   generator:
     excludes: []
   enricher:
-    excludes: []
+    excludes:
+      - jkube-ingress
+      - jkube-openshift-route
diff --git a/kubernetes-maven-plugin/doc/src/main/asciidoc/inc/_profiles.adoc b/kubernetes-maven-plugin/doc/src/main/asciidoc/inc/_profiles.adoc
@@ -202,7 +202,7 @@ This plugin comes with a list of the following predefined profiles:
 | Includes no generators and only the <<jkube-dependency,jkube-dependency>> enricher for picking up and combining resources from the compile time dependencies.
 
 | *internal-microservice*
-| Do not expose a port for the service to generate. Otherwise the same as the _default_ profile.
+|  _default_ profile extension that prevents services from being externally exposed.
 
 | *osio*
 | Includes everything in the _default_ profile, plus additional enrichers and generators relevant only to https://openshift.io[OpenShift.io].

diff --git a/kubernetes-maven-plugin/plugin/src/main/resources/META-INF/jkube/profiles-default.yml b/kubernetes-maven-plugin/plugin/src/main/resources/META-INF/jkube/profiles-default.yml
@@ -154,4 +154,6 @@
   generator:
     excludes: []
   enricher:
-    excludes: []
+    excludes:
+      - jkube-ingress
+      - jkube-openshift-route
diff --git a/openshift-maven-plugin/plugin/src/main/resources/META-INF/jkube/profiles-default.yml b/openshift-maven-plugin/plugin/src/main/resources/META-INF/jkube/profiles-default.yml
@@ -149,4 +149,6 @@
   generator:
     excludes: []
   enricher:
-    excludes: []
+    excludes:
+      - jkube-ingress
+      - jkube-openshift-route