Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Openshift specific functionality from Kubernetes Maven Plugin (KMP) #101

Closed
3 tasks done
manusa opened this issue Mar 9, 2020 · 0 comments
Closed
3 tasks done
Assignees
Milestone

Comments

@manusa
Copy link
Member

manusa commented Mar 9, 2020

Description

As of now, both Maven plugins (Openshift + Kubernetes) are just ports of Fabric8 Maven Plugin (FMP) with different names.
FMP provides functionality for both cluster brands. AS KMP is just a port of FMP, we can still see traces of OpenShift specifics in the codebase (e.g. s2i, openshiftPullSecret, openshiftDeployTimeoutSeconds...)

All of these properties and configurations should be moved to the appropriate plugin.

Tasks:

  • Modify affected Mojos
  • Update plugin documentation to reflect new state + flags
  • Change jkube-website to generate documentation for both plugins using the configurable kubernetes-maven-plugin-doc

Relates to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant