refactor: Removed OpenShift specific config flags from kubernetes-maven-plugin #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manusa
force-pushed
the
refactor/openshift-in-oc
branch
from
1f79fae
to
627ad65
Compare
...maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/develop/WatchMojo.java
Outdated
Show resolved
Hide resolved
.../plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/develop/OpenshiftUndeployMojo.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
============================================
- Coverage 26.25% 26.21% -0.04%
+ Complexity 1575 1572 -3
============================================
Files 347 349 +2
Lines 18281 18280 -1
Branches 2812 2813 +1
============================================
- Hits 4799 4793 -6
- Misses 12923 12927 +4
- Partials 559 560 +1
Continue to review full report at Codecov.
|
manusa
force-pushed
the
refactor/openshift-in-oc
branch
3 times, most recently
from
db42762
to
2b51715
Compare
...-maven-plugin/plugin/src/main/java/org/eclipse/jkube/maven/plugin/mojo/ManifestProvider.java
Outdated
Show resolved
Hide resolved
…en-plugin - Enhanced OpenshiftUndeployMojo to remove Build resources along with the BuildConfigs Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
refactor/openshift-in-oc
branch
from
2b51715
to
774b424
Compare
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will create an additional PR with documentation and updated Changelog.
Relates to: #101