Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot temporarily tag because target image already exists #1232

Closed
lagivan opened this issue Jan 25, 2022 · 2 comments · Fixed by #1233
Closed

Cannot temporarily tag because target image already exists #1232

lagivan opened this issue Jan 25, 2022 · 2 comments · Fixed by #1233
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lagivan
Copy link
Contributor

lagivan commented Jan 25, 2022

Description

This is the same issue that was created and fixed for docker-maven-plugin several years ago - fabric8io/docker-maven-plugin#838
Here is the fix - https://github.com/fabric8io/docker-maven-plugin/pull/1170/files
The relevant code - https://github.com/eclipse/jkube/blob/85d9fe8fd17e59eb1cdb07da194e6419201585d1/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/access/hc/DockerAccessWithHcClient.java#L661-L666

My problem is that I want to tag the image with "latest" version which already exists in the repo but pushing this new image should remove "latest" tag from an older image. This is impossible to do now.

Info

  • Eclipse JKube version : 1.5.1
  • Maven version (mvn -v) : 3.6.2
  • If it's a bug, how to reproduce :

This is my plugin configuration - using "%l" in the image name should set "latest" tag for SNAPSHOT artifacts.

        <plugin>
            <groupId>org.eclipse.jkube</groupId>
            <artifactId>kubernetes-maven-plugin</artifactId>
            <version>1.5.1</version>
            <configuration>
                <profile>myapp</profile>
                <access>
                    <namespace>test</namespace>
                </access>
                <registry>XXX.dkr.ecr.eu-west-1.amazonaws.com</registry>
                <images>
                    <image>
                        <name>myapp:%l</name>
                        <alias>myapp</alias>
                        <build>
                            <contextDir>.</contextDir>
                        </build>
                    </image>
                </images>
            </configuration>
        </plugin>
@rohanKanojia
Copy link
Member

@lagivan : Thanks for reporting this. We're close to releasing a new version 1.6.0 (most probably this week) . Would it be possible for you to port this fix to JKube ?

@lagivan
Copy link
Contributor Author

lagivan commented Jan 25, 2022

@rohanKanojia done, I'm looking forward to getting it fixed in 1.6.0

@manusa manusa added the bug Something isn't working label Jan 26, 2022
@manusa manusa added this to the 1.6.0 milestone Jan 26, 2022
@manusa manusa moved this to Review in Eclipse JKube Feb 2, 2022
Repository owner moved this from Review to Done in Eclipse JKube Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants