-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should suggest to use jkube.domain
if createExternalUrls
is used without domain.
#1439
Comments
…teExternalUrls` is used without domain (eclipse-jkube#1439) Currently value for IngressRule's `.host` field depends either on `HOST` enricher configuration or `jkube.domain` configuration. If none of these options are provided, we set `.spec.defaultBackend`. Add a hint to suggest specifying `jkube.domain` in case no value for host is found. Signed-off-by: Rohan Kumar <[email protected]>
I've created PR #1980 to add this hint : However, I have a feeling that this hint might not be clearly visible. It might get lost in logs.
Maybe I'm thinking a bit too far but shall we make changes so that these |
I'm not sure I'd call this "Hint service" but this should definitely go in the summary. |
…teExternalUrls` is used without domain (#1439) Currently value for IngressRule's `.host` field depends either on `HOST` enricher configuration or `jkube.domain` configuration. If none of these options are provided, we set `.spec.defaultBackend`. Add a hint to suggest specifying `jkube.domain` in case no value for host is found. Signed-off-by: Rohan Kumar <[email protected]>
Description
I have recently been using
jkube.createExternalUrls
but forgot to set the domain. Would be nice to log aHINT
message with the suggestion.The text was updated successfully, but these errors were encountered: