Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IngressEnricher seems to be broken #184

Closed
manusa opened this issue May 7, 2020 · 1 comment · Fixed by #213
Closed

IngressEnricher seems to be broken #184

manusa opened this issue May 7, 2020 · 1 comment · Fixed by #213
Assignees
@rohanKanojia
Labels
bug Something isn't working
Milestone
1.0.0

Comments

@manusa
Copy link
Member

manusa commented May 7, 2020

Description

The following code seems to be ignoring the ingressBuilder
(see FMP version).

https://github.com/eclipse/jkube/blob/9e3d67371e8c12bc8aa6288acacc83d1f796ea96/jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/IngressEnricher.java#L62-L80
@manusa manusa added the bug Something isn't working label May 7, 2020
@manusa manusa added this to the 1.0.0 milestone May 7, 2020
@manusa
Copy link
Member Author

manusa commented May 8, 2020

This PR https://github.com/fabric8io/fabric8-maven-plugin/pull/1730/files

Wasn't ported apparently.

@rohanKanojia rohanKanojia self-assigned this May 28, 2020
@rohanKanojia rohanKanojia mentioned this issue May 28, 2020
Merged
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 28, 2020
@rohanKanojia
Fix eclipse-jkube#184: IngressEnricher seems to be broken
0435369 
Ported PR fabric8io/fabric8-maven-plugin#1730
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 28, 2020
@rohanKanojia
Fix eclipse-jkube#184: IngressEnricher seems to be broken
97f8e22 
Ported PR fabric8io/fabric8-maven-plugin#1730
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 4, 2020
@rohanKanojia
Fix eclipse-jkube#184: IngressEnricher seems to be broken
ca6c7a3 
Ported PR fabric8io/fabric8-maven-plugin#1730
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 4, 2020
@rohanKanojia
Fix eclipse-jkube#184: IngressEnricher seems to be broken
19c800c 
Ported PR fabric8io/fabric8-maven-plugin#1730
@manusa manusa mentioned this issue Jun 4, 2020
Closed
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 4, 2020
@rohanKanojia
Fix eclipse-jkube#184: IngressEnricher seems to be broken
d3f6e45 
Ported PR fabric8io/fabric8-maven-plugin#1730
manusa pushed a commit that referenced this issue Jun 5, 2020
@rohanKanojia @manusa
Fix #184: IngressEnricher seems to be broken
e11392a 
Ported PR fabric8io/fabric8-maven-plugin#1730
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Fix #184: IngressEnricher seems to be broken rohanKanojia/jkube
2 participants
@manusa @rohanKanojia