Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since v1.11.0, <serviceAccount> configuration option has stopped working. ServiceAccount reference was removed from PodTemplateHandler in https://github.com/eclipse/jkube/pull/1969 #2187

Closed
manusa opened this issue May 31, 2023 · 0 comments · Fixed by #2190
Closed

Since v1.11.0, <serviceAccount> configuration option has stopped working. ServiceAccount reference was removed from PodTemplateHandler in https://github.com/eclipse/jkube/pull/1969 #2187

manusa opened this issue May 31, 2023 · 0 comments · Fixed by #2190
Assignees
@rohanKanojia
Labels
bug Something isn't working
Milestone
1.13.0

Comments

@manusa
Copy link
Member

manusa commented May 31, 2023 •
edited
Loading 

          Since v1.11.0, `<serviceAccount>` configuration option has stopped working. ServiceAccount reference was removed from PodTemplateHandler in https://github.com/eclipse/jkube/pull/1969

Before v1.11.0, it used to work for zero configuration mode but not when user provides a deployment fragment.

#1969

Originally posted by @rohanKanojia in #1758 (comment)

As a user I want to be able to specify the ServiceAccount to be used or referenced in my Pod serviceAccountName, more specifically I want my Controller Kubernetes Objects (such as Deployment, Job, ReplicaSet, and so on) to have a PodTemplate spec with this reference.

I want to be able to achieve this either by providing a PodTemplate fragment, or through configurations that I can override when executing the plugins (Maven or Gradle)

  • ✔️ Fragments are working
  • ✖️ Project/CLI/property configuration has stopped working
@manusa manusa added this to the 1.13.0 milestone May 31, 2023
@manusa manusa added the bug Something isn't working label May 31, 2023
@manusa manusa moved this to Planned in Eclipse JKube May 31, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 31, 2023
@rohanKanojia
test (gradle-plugin/it) : Add test for setting ServiceAccount name in…
d6be6b8 
… generated controller (eclipse-jkube#2187)

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia mentioned this issue May 31, 2023
Merged
17 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 31, 2023
@rohanKanojia
test (gradle-plugin/it) : Add test for setting ServiceAccount name in…
c7e7818 
… generated controller (eclipse-jkube#2187)

Signed-off-by: Rohan Kumar <[email protected]>
manusa pushed a commit that referenced this issue May 31, 2023
@rohanKanojia @manusa
test (gradle-plugin/it) : Add test for setting ServiceAccount name in…
7d7fda3 
… generated controller (#2187)

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia self-assigned this Jun 1, 2023
@rohanKanojia rohanKanojia moved this from Planned to In Progress in Eclipse JKube Jun 1, 2023
@rohanKanojia rohanKanojia linked a pull request Jun 1, 2023 that will close this issue
fix (jkube-kit/enricher) : Merge serviceAccount and serviceAccounts configuration options (#1758) #1889
Closed
17 tasks
@rohanKanojia rohanKanojia moved this from In Progress to Review in Eclipse JKube Jun 1, 2023
@rohanKanojia rohanKanojia removed a link to a pull request Jun 1, 2023
fix (jkube-kit/enricher) : Merge serviceAccount and serviceAccounts configuration options (#1758) #1889
Closed
17 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 1, 2023
@rohanKanojia
fix (jkube-kit/enricher) : ServiceAccountEnricher handles `serviceAcc…
4c8e49b 
…ount` configuration option (eclipse-jkube#2187)

ServiceAccountEnricher used to only handle `serviceAccounts`
resource configuration option. `serviceAccount` used to be used by
PodTemplateHandler while generating opinionated controllers.

Add a case for handling `serviceAccount` in ServiceAccountEnricher

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia mentioned this issue Jun 1, 2023
Merged
17 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Jun 1, 2023
@rohanKanojia
fix (jkube-kit/enricher) : ServiceAccountEnricher handles `serviceAcc…
c301fe3 
…ount` configuration option (eclipse-jkube#2187)

ServiceAccountEnricher used to only handle `serviceAccounts`
resource configuration option. `serviceAccount` used to be used by
PodTemplateHandler while generating opinionated controllers.

Add a case for handling `serviceAccount` in ServiceAccountEnricher

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia moved this from Review to In Progress in Eclipse JKube Jun 2, 2023
@manusa manusa moved this from In Progress to Review in Eclipse JKube Jun 2, 2023
manusa pushed a commit that referenced this issue Jun 2, 2023
@rohanKanojia @manusa
fix (jkube-kit/enricher) : ServiceAccountEnricher handles `serviceAcc…
52297f1 
…ount` configuration option (#2187)

ServiceAccountEnricher used to only handle `serviceAccounts`
resource configuration option. `serviceAccount` used to be used by
PodTemplateHandler while generating opinionated controllers.

Add a case for handling `serviceAccount` in ServiceAccountEnricher

Signed-off-by: Rohan Kumar <[email protected]>
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
bug Something isn't working
Projects
None yet
Milestone
1.13.0
2 participants
@manusa @rohanKanojia