Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to specify OpenShift push secret via property via OpenShift Gradle Plugin #2414

Closed
rohanKanojia opened this issue Oct 6, 2023 · 0 comments · Fixed by #2415
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rohanKanojia
Copy link
Member

Describe the bug

While pushing image to external registry using ocBuild task, registry push secret doesn't get picked up by OpenShift Gradle Plugin when I provide it via property:

jkube.build.pushSecret=dockerhub-secret

However, if I specify it from OpenShift plugin groovy DSL configuration, it does get picked up:

openshift {
    openshiftPushSecret = 'dockerhub-secret'
}

Eclipse JKube version

SNAPSHOT

Component

OpenShift Gradle Plugin

Apache Maven version

None

Gradle version

other (please specify in additional context)

Steps to reproduce

Try pushing image to some external registry using OpenShift Gradle Plugin, provide authentication secret via property instead of groovy configuration

Expected behavior

jkube.build.pushSecret should be picked up by OpenShift Gradle Plugin

Runtime

OpenShift

Kubernetes API Server version

1.25.3

Environment

Linux

Eclipse JKube Logs

No response

Sample Reproducer Project

No response

Additional context

No response

@rohanKanojia rohanKanojia added the bug Something isn't working label Oct 6, 2023
@rohanKanojia rohanKanojia self-assigned this Oct 6, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Oct 6, 2023
…pushSecret` property (eclipse-jkube#2414)

Add getOpenshiftPushSecretOrDefault method in OpenShiftExtension to pick
up configuration value from property if it's not provided in groovy dsl

Signed-off-by: Rohan Kumar <[email protected]>
@manusa manusa moved this to In Progress in Eclipse JKube Oct 6, 2023
@manusa manusa added this to the 1.15.0 milestone Oct 6, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Oct 6, 2023
…pushSecret` property (eclipse-jkube#2414)

Add getOpenshiftPushSecretOrDefault method in OpenShiftExtension to pick
up configuration value from property if it's not provided in groovy dsl

Signed-off-by: Rohan Kumar <[email protected]>
@manusa manusa moved this from In Progress to Review in Eclipse JKube Oct 10, 2023
manusa pushed a commit that referenced this issue Oct 10, 2023
…pushSecret` property (#2414)

Add getOpenshiftPushSecretOrDefault method in OpenShiftExtension to pick
up configuration value from property if it's not provided in groovy dsl

Signed-off-by: Rohan Kumar <[email protected]>
@github-project-automation github-project-automation bot moved this from Review to Done in Eclipse JKube Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants