New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port d-m-p fix for #1359 #1360 #339

Closed

manusa opened this issue Aug 4, 2020 · 0 comments · Fixed by #361

Assignees

Labels

bug good first issue

Milestone

Member

manusa commented Aug 4, 2020 •

edited

Loading

Description

Port changes in Docker Maven Plugin:

This fix swaps the logic for:
https://github.com/eclipse/jkube/blob/67e5982f160ce1c830982a3c9ace41c470b36857/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java#L64-L68

which means that https protocol will be chosen by default.

See also:

IANA registered Docker ports

The text was updated successfully, but these errors were encountered:

manusa added bug good first issue labels

manusa added this to the 1.0.0 milestone

rohanKanojia self-assigned this

rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue


          Fix eclipse-jkube#339: Https should be considered default while conve…

a6e388a

…rting tcp urls

rohanKanojia mentioned this issue

Fix #339: Https should be considered default while converting tcp urls #361

Merged

12 tasks

manusa closed this as completed in #361

manusa pushed a commit that referenced this issue


          Fix #339: Https should be considered default while converting tcp urls

a8a7bf8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment