Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yaml extract for routes #382

Closed
jfdenise opened this issue Sep 14, 2020 · 0 comments · Fixed by #406
Closed

Yaml extract for routes #382

jfdenise opened this issue Sep 14, 2020 · 0 comments · Fixed by #406
Assignees
@rohanKanojia
Labels
bug Something isn't working
Milestone
1.0.1

Comments

@jfdenise
Copy link
Contributor

Description

The goal is to evolve a generated route with support for https. Adding something like to the spec:

spec:
  tls:
    insecureEdgeTerminationPolicy: Redirect
    termination: edge

It is not clear on how this should be handled. Currently custom spec element is not merged with the spec element of the generated route, the generated route's spec element is replaced with the content of the extract file. NB: this can be acceptable although the documentation doesn't state how to customize routes.

Info

  • Eclipse JKube version : 1.0.0

  • If it's a bug, how to reproduce : add a route.yml extract in the src/jkube directory of a quickstart.
@manusa manusa added the bug Something isn't working label Sep 14, 2020
@manusa manusa added this to the 1.0.1 milestone Sep 14, 2020
@rohanKanojia rohanKanojia self-assigned this Sep 24, 2020
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 24, 2020
@rohanKanojia
Fix eclipse-jkube#382: Add support for merging fragment Route spec wi…
6cf12ba 
…th default generated Route
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 25, 2020
@rohanKanojia
Fix eclipse-jkube#382: Add support for merging fragment Route spec wi…
9e2219d 
…th default generated Route
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 25, 2020
@rohanKanojia
Fix eclipse-jkube#382: Add support for merging fragment Route spec wi…
10df4d9 
…th default generated Route
@rohanKanojia rohanKanojia mentioned this issue Sep 25, 2020
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 28, 2020
@rohanKanojia
Fix eclipse-jkube#382: Add support for merging fragment Route spec wi…
fca541f 
…th default generated Route
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 28, 2020
@rohanKanojia
Fix eclipse-jkube#382: Add support for merging fragment Route spec wi…
5a9672b 
…th default generated Route
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 29, 2020
@rohanKanojia
Fix eclipse-jkube#382: Add support for merging fragment Route spec wi…
08b3d8a 
…th default generated Route
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 29, 2020
@rohanKanojia
Fix eclipse-jkube#382: Add support for merging fragment Route spec wi…
95fabac 
…th default generated Route
manusa pushed a commit that referenced this issue Sep 30, 2020
@rohanKanojia @manusa
Fix #382: Add support for merging fragment Route spec with default ge…
63bde26 
…nerated Route
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.1
3 participants
@manusa @jfdenise @rohanKanojia