Fix #1053: Add ocHelm task to OpenShift Gradle Plugin #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1072 +/- ##
============================================
+ Coverage 48.95% 48.98% +0.02%
- Complexity 3630 3634 +4
============================================
Files 455 456 +1
Lines 20738 20752 +14
Branches 2827 2827
============================================
+ Hits 10153 10165 +12
- Misses 9499 9501 +2
Partials 1086 1086
Continue to review full report at Codecov.
|
rohanKanojia
force-pushed
the
pr/issue1053
branch
from
955da63
to
2b5481c
Compare
manusa
reviewed
Oct 27, 2021
gradle-plugin/openshift/src/main/java/org/eclipse/jkube/gradle/plugin/OpenShiftExtension.java
Outdated
Show resolved
Hide resolved
manusa
reviewed
Oct 27, 2021
gradle-plugin/openshift/src/main/java/org/eclipse/jkube/gradle/plugin/OpenShiftExtension.java
Outdated
Show resolved
Hide resolved
Move manifest not found warning message into a method so that it can be overridden in case of OpenShiftHelmMojo Signed-off-by: Rohan Kumar <[email protected]>
…fests and template The property name seems to be a typo and openshiftManifest field should have `jkube.openshiftManifest` as property name instead of `jkube.kubernetesManifest` Signed-off-by: Rohan Kumar <[email protected]>
Implement `oc:helm` equivalent functionality `ocHelm` for OpenShift Gradle Plugin. Signed-off-by: Rohan Kumar <[email protected]>
We had getOpenShiftManifestOrDefault method in OpenShiftExtension which was used for getting openshift manifests in case of OpenShift. However, this seemed redundant as we had getManifest method in KubernetesExtension(overridden in OpenShiftExtension) for same task. To keep it simple, remove getOpenShiftManifstOrDefault method from OpenShiftExtension and override getKubernetesManifestOrDefault method in OpenShiftExtension Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/issue1053
branch
from
2b5481c
to
b693e5f
Compare
manusa
reviewed
Oct 27, 2021
Comment on lines
+119
to
+121
| public File getKubernetesTemplateOrDefault() { | ||
| return getOrDefaultFile("jkube.kubernetesTemplate", this::getKubernetesTemplate, javaProject.getOutputDirectory().toPath().resolve(DEFAULT_OPENSHIFT_TEMPLATE).toFile()); | ||
| } |
There was a problem hiding this comment.
Add a test for this in KubernetesExtensionPropertyTest + OpenShiftExtensionPropertyTest
There was a problem hiding this comment.
There is a test already in KubernetesExtensionPropertyTest, I'll add the test in OpenShiftExtensionPropertyTest
There was a problem hiding this comment.
👍 I was checking on an outdated branch
…efault Add test for getKubernetesTemplateOrDefault's overridden implementation in OpenShiftExtension Signed-off-by: Rohan Kumar <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
manusa
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #1053
Ported OpenShiftHelmMojo to openshift gradle plugin .Implement
oc:helmequivalent functionalityocHelmfor OpenShiftGradle Plugin.
Signed-off-by: Rohan Kumar [email protected]
Type of change
test, version modification, documentation, etc.)
Checklist