Fix #887: Incorrect warning about overriding environment variable #1108
+68
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1108 +/- ##
============================================
+ Coverage 48.98% 49.03% +0.05%
- Complexity 3634 3637 +3
============================================
Files 456 456
Lines 20753 20751 -2
Branches 2827 2827
============================================
+ Hits 10165 10175 +10
+ Misses 9502 9494 -8
+ Partials 1086 1082 -4
Continue to review full report at Codecov.
|
manusa
reviewed
Nov 11, 2021
jkube-kit/enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/ImageEnricher.java
Outdated
Show resolved
Hide resolved
… variable Don't log warning about not overriding environment variable when both old and new values are same. Signed-off-by: Rohan Kumar <[email protected]>
rohanKanojia
force-pushed
the
pr/issue887
branch
from
02c5671
to
9c9d274
Compare
|
Kudos, SonarCloud Quality Gate passed! |
manusa
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #887
Don't log a warning about not overriding environment variable when both
old and new values are same.
Signed-off-by: Rohan Kumar [email protected]
Type of change
test, version modification, documentation, etc.)
Checklist