Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: OpenShift pull secret not picked up without registry auth configuration #171

Merged
merged 1 commit into from
Apr 29, 2020
Merged

fix: OpenShift pull secret not picked up without registry auth configuration #171

merged 1 commit into from
Apr 29, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Apr 29, 2020 •
edited
Loading

No description provided.

@manusa manusa changed the title fix: OpenShift pull secret not picked up without registry auth config… fix: OpenShift pull secret not picked up without registry auth configuration Apr 29, 2020
juazugas
juazugas approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@juazugas juazugas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Apr 29, 2020 •
edited
Loading

Codecov Report

Merging #171 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #171      +/-   ##
============================================
- Coverage     26.21%   26.21%   -0.01%     
  Complexity     1572     1572              
============================================
  Files           349      349              
  Lines         18280    18282       +2     
  Branches       2813     2812       -1     
============================================
  Hits           4793     4793              
- Misses        12927    12929       +2     
  Partials        560      560
Impacted Files Coverage Δ Complexity Δ
...kit/build/core/assembly/DockerAssemblyManager.java 41.86% <0.00%> (-0.40%) 27.00 <0.00> (ø)
...onfig/service/openshift/OpenshiftBuildService.java 53.08% <0.00%> (ø) 46.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3b31d...27180f8. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa self-assigned this Apr 29, 2020
@manusa manusa mentioned this pull request Apr 29, 2020
Closed
rohanKanojia
rohanKanojia approved these changes Apr 29, 2020
View reviewed changes
Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @manusa @juazugas 🎉

@rohanKanojia rohanKanojia merged commit b294c87 into eclipse-jkube:master Apr 29, 2020
@manusa manusa deleted the fix/openshift-pullsecret branch April 29, 2020 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@juazugas juazugas juazugas approved these changes

@devang-gaur devang-gaur Awaiting requested review from devang-gaur

Assignees

@manusa manusa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manusa @juazugas @rohanKanojia