Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wildfly example works in OpenShift with s2i binary #198

Merged
merged 1 commit into from
May 12, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented May 12, 2020

  • Updated jboss-wildfly image version
  • Fixed Quickstart configuration
  • Added required permissions to standalone directory so that any "randomized" user can start the app server

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #198 into master will decrease coverage by 0.01%.
The diff coverage is 52.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
- Coverage     26.23%   26.22%   -0.02%     
- Complexity     1571     1576       +5     
============================================
  Files           349      350       +1     
  Lines         18277    18275       -2     
  Branches       2810     2806       -4     
============================================
- Hits           4795     4792       -3     
- Misses        12923    12926       +3     
+ Partials        559      557       -2     
Impacted Files Coverage Δ Complexity Δ
...kit/config/image/build/OpenShiftBuildStrategy.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...lipse/jkube/generator/webapp/AppServerHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...clipse/jkube/generator/webapp/WebAppGenerator.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...generator/webapp/handler/JettyAppSeverHandler.java 25.00% <33.33%> (ø) 3.00 <1.00> (ø)
...enerator/webapp/handler/TomcatAppSeverHandler.java 25.00% <33.33%> (ø) 3.00 <1.00> (ø)
...nerator/webapp/handler/WildFlyAppSeverHandler.java 33.33% <37.50%> (-6.67%) 9.00 <9.00> (+4.00) ⬇️
...rator/webapp/handler/AbstractAppServerHandler.java 90.00% <80.00%> (+0.52%) 10.00 <3.00> (+1.00)
...onfig/service/openshift/OpenshiftBuildService.java 53.01% <80.95%> (-0.08%) 46.00 <4.00> (ø)
...ipse/jkube/generator/webapp/AppServerDetector.java 93.33% <100.00%> (ø) 6.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8973d6c...71f0552. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 12, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

63.9% 63.9% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 332c121 into eclipse-jkube:master May 12, 2020
@manusa manusa deleted the fix/wildfly branch May 12, 2020 14:23
@manusa manusa mentioned this pull request May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants