Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike: JavaExecGenerator uses ubi8/openjdk-11 always #203

Closed
wants to merge 1 commit into from

Conversation

manusa
Copy link
Member

@manusa manusa commented May 15, 2020

This is PoC PR intended for review of options regarding base image replacements (#183)

What this PR accomplishes is the use of registry.access.redhat.com/ubi8/openjdk-11 image for all build strategies.
The main advantage for this is the reduced complexity in maintenance, as configuration should only deal with one image type.

We're also replacing 2 different fabric8 maintained images for a single community-driven image.

In order to be able to use the s2i builder image both as a builder image and as a runtime image is by providing the packaged artifacts in the specific directory for s2i assembly (/tmp/src/deployments). And by adding the COPY statement from deployments to /deployments in the generated Dockerfile.

@manusa manusa added the WIP Work in Progress label May 15, 2020
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #203 into master will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #203   +/-   ##
=========================================
  Coverage     26.27%   26.28%           
  Complexity     1589     1589           
=========================================
  Files           350      350           
  Lines         18296    18293    -3     
  Branches       2808     2808           
=========================================
+ Hits           4807     4808    +1     
+ Misses        12931    12927    -4     
  Partials        558      558           
Impacted Files Coverage Δ Complexity Δ
...be/openliberty/generator/OpenLibertyGenerator.java 75.00% <80.00%> (+7.50%) 5.00 <1.00> (ø)
...se/jkube/generator/javaexec/JavaExecGenerator.java 83.16% <100.00%> (+0.16%) 22.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f3f70b...26f2856. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rohanKanojia
Copy link
Member

@manusa : Is this ready for review?

@manusa
Copy link
Member Author

manusa commented May 21, 2020

This is closed by #205.

It was a PoC showcasing how to use unmodified community-based upstream images.

#205 approach is preferred because 100 MiB are stripped off of the upstream image and not much maintenance is required since it's based in community maintained CEKit modules.

@manusa manusa closed this May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants