spike: JavaExecGenerator uses ubi8/openjdk-11 always #203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PoC PR intended for review of options regarding base image replacements (#183)
What this PR accomplishes is the use of
registry.access.redhat.com/ubi8/openjdk-11
image for all build strategies.The main advantage for this is the reduced complexity in maintenance, as configuration should only deal with one image type.
We're also replacing 2 different fabric8 maintained images for a single community-driven image.
In order to be able to use the s2i builder image both as a builder image and as a runtime image is by providing the packaged artifacts in the specific directory for s2i assembly (
/tmp/src/deployments
). And by adding the COPY statement from deployments to/deployments
in the generated Dockerfile.