fix: KarafGenerator update

[manusa]

• Created Karaf Quickstart
• Fixed problems with FileSet assembly config to include complete directories
• Upgraded images to use quay.io/jkube/jkube-karaf-binary-s2i

n.b. CompleteK8sITCase will fail due to an invalid assertion. In the past filesets entries were copied (in all cases) to the target directory under a subdirectory named like the source parent directory, which is wrong.)
The failing line should be replaced

• From:

assertThat(imageFiles, hasItem("/deployments/jkube-includes/will-be-included-if-no-assemblies-defined.txt"));

• To:

    assertThat(imageFiles, hasItem("/deployments/will-be-included-if-no-assemblies-defined.txt"));

I'll update integration-tests once this PR gets merged.

Relates to: #183 #188 #94

[codecov]

Codecov Report

Merging #214 into master will increase coverage by 0.31%.
The diff coverage is 90.62%.

@@             Coverage Diff              @@
##             master     #214      +/-   ##
============================================
+ Coverage     26.76%   27.08%   +0.31%     
- Complexity     1626     1661      +35     
============================================
  Files           350      351       +1     
  Lines         18308    18323      +15     
  Branches       2801     2804       +3     
============================================
+ Hits           4900     4962      +62     
+ Misses        12848    12799      -49     
- Partials        560      562       +2     

Impacted Files	Coverage Δ	Complexity Δ
...re/assembly/DockerAssemblyConfigurationSource.java	61.53% <ø> (ø)	9.00 <0.00> (ø)
...kit/build/core/assembly/DockerAssemblyManager.java	48.66% <0.00%> (+6.33%)	27.00 <0.00> (ø)
...core/assembly/JKubeAssemblyConfigurationUtils.java	96.15% <ø> (ø)	5.00 <0.00> (ø)
...e/jkube/kit/build/service/docker/BuildService.java	0.00% <ø> (ø)	0.00 <0.00> (ø)
...config/handler/property/PropertyConfigHandler.java	0.00% <ø> (ø)	0.00 <0.00> (ø)
...clipse/jkube/kit/common/AssemblyConfiguration.java	8.33% <ø> (ø)	2.00 <0.00> (?)
...ava/org/eclipse/jkube/kit/common/AssemblyMode.java	0.00% <ø> (ø)	0.00 <0.00> (?)
...ube/kit/config/image/build/BuildConfiguration.java	20.30% <ø> (ø)	20.00 <0.00> (ø)
...onfig/service/openshift/OpenshiftBuildService.java	53.01% <ø> (ø)	46.00 <0.00> (ø)
...clipse/jkube/generator/webapp/WebAppGenerator.java	88.00% <ø> (ø)	13.00 <0.00> (ø)
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2076887...1a5ae1e. Read the comment docs.

[sonarcloud]

SonarCloud Quality Gate failed.

1 Bug
0 Vulnerabilities (and 0 Security Hotspots to review)
20 Code Smells

32.0% Coverage
0.0% Duplication

The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here