Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactored FileUtil#getRelativeFilePath to use native Java File capabilities #226

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jun 3, 2020

No description provided.

@manusa manusa self-assigned this Jun 3, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #226 into master will increase coverage by 0.11%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #226      +/-   ##
============================================
+ Coverage     27.28%   27.39%   +0.11%     
- Complexity     1665     1669       +4     
============================================
  Files           353      353              
  Lines         18356    18313      -43     
  Branches       2799     2783      -16     
============================================
+ Hits           5008     5017       +9     
+ Misses        12785    12732      -53     
- Partials        563      564       +1     
Impacted Files Coverage Δ Complexity Δ
...va/org/eclipse/jkube/kit/common/util/FileUtil.java 65.51% <88.88%> (+28.59%) 27.00 <4.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c3cc87...0b34209. Read the comment docs.

@manusa manusa added this to the 1.0.0 milestone Jun 3, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

94.1% 94.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@rohanKanojia rohanKanojia merged commit 79b6fae into eclipse-jkube:master Jun 3, 2020
@manusa manusa deleted the refactor/file-util branch June 3, 2020 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants