Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Provided Slf4j delegate KitLogger implementation #233

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jun 5, 2020

Description

Provided Slf4j delegate KitLogger implementation

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@manusa manusa force-pushed the feature/slf4j-kitlogger branch from d8833b0 to 0316d3e Compare June 5, 2020 10:12
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #233 into master will decrease coverage by 0.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #233      +/-   ##
============================================
- Coverage     28.13%   27.44%   -0.69%     
+ Complexity     1689     1675      -14     
============================================
  Files           353      354       +1     
  Lines         18186    18322     +136     
  Branches       2758     2781      +23     
============================================
- Hits           5117     5029      -88     
- Misses        12470    12729     +259     
+ Partials        599      564      -35     
Impacted Files Coverage Δ Complexity Δ
...n/java/org/eclipse/jkube/kit/common/KitLogger.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
.../eclipse/jkube/kit/common/util/Slf4jKitLogger.java 100.00% <100.00%> (ø) 6.00 <6.00> (?)
...kube/enricher/generic/openshift/RouteEnricher.java 0.00% <0.00%> (-59.26%) 0.00% <0.00%> (-10.00%)
...clipse/jkube/enricher/generic/IngressEnricher.java 0.00% <0.00%> (-58.43%) 0.00% <0.00%> (-10.00%)
...g/eclipse/jkube/kit/enricher/api/BaseEnricher.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ipse/jkube/kit/config/resource/ResourceConfig.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...lipse/jkube/maven/plugin/mojo/build/ApplyMojo.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...se/jkube/maven/plugin/mojo/build/ResourceMojo.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ube/enricher/generic/DefaultNamespaceEnricher.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ube/enricher/generic/openshift/ExposeEnricher.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e11392a...0316d3e. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa manusa merged commit 0fe957a into eclipse-jkube:master Jun 5, 2020
@manusa manusa deleted the feature/slf4j-kitlogger branch June 5, 2020 10:44
@manusa manusa added this to the 1.0.0 milestone Jun 5, 2020
@manusa manusa self-assigned this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants