Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Docker-file-simple quickstart #241

Merged

Conversation

manusa
Copy link
Member

@manusa manusa commented Jun 11, 2020

Description

Refactored docker-file-simple (zero-config-dockerfile)

  • Renamed to make consistent with rest of docker-file examples
  • Removed unnecessary dependencies + tests to speed up build times (quickstarts CI job)
  • Added minimum configuration to expose a service
  • Made application runnable
  • Static file is served from rest endpoint

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@manusa manusa added the WIP Work in Progress label Jun 11, 2020
@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #241 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #241   +/-   ##
=========================================
  Coverage     28.73%   28.73%           
  Complexity     1731     1731           
=========================================
  Files           355      355           
  Lines         18235    18235           
  Branches       2764     2764           
=========================================
  Hits           5240     5240           
  Misses        12377    12377           
  Partials        618      618           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07477a2...da6b628. Read the comment docs.

- Removed unnecessary dependencies + tests to speed up build times (quickstarts CI job)
- Added minimum configuration to expose a service
- Made application runnable
- Static file is served from rest endpoint

Signed-off-by: Marc Nuri <[email protected]>
@manusa manusa force-pushed the refactor/docker-file-simple branch from afb8764 to da6b628 Compare June 11, 2020 06:51
@manusa manusa removed the WIP Work in Progress label Jun 11, 2020
@sonarcloud
Copy link

sonarcloud bot commented Jun 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@rohanKanojia rohanKanojia merged commit 02155e6 into eclipse-jkube:master Jun 11, 2020
@manusa manusa deleted the refactor/docker-file-simple branch June 11, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants