Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved MigrateMojo #255

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Jun 22, 2020

Description

  • pluginManagement pom.xml entries are now considered (both in profile and build)
  • Granular control for fmp- f8- prefix replacements (only where applicable)
  • Improved MigrateService IT suite, validate complete expected pom.xml
  • "Mergeable" fragment directory (idempotent migrate goal)
  • Rafactored LazyBuilder

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

Relates to: #195

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #255 into master will increase coverage by 0.07%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #255      +/-   ##
============================================
+ Coverage     29.52%   29.60%   +0.07%     
- Complexity     1818     1833      +15     
============================================
  Files           358      358              
  Lines         18316    18329      +13     
  Branches       2760     2755       -5     
============================================
+ Hits           5408     5426      +18     
+ Misses        12284    12278       -6     
- Partials        624      625       +1     
Impacted Files Coverage Δ Complexity Δ
...ipse/jkube/maven/plugin/mojo/util/MigrateMojo.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...ipse/jkube/kit/config/service/JKubeServiceHub.java 84.09% <80.00%> (+3.23%) 17.00 <3.00> (+3.00)
...lipse/jkube/kit/common/service/MigrateService.java 84.21% <83.78%> (-7.60%) 24.00 <24.00> (+7.00) ⬇️
...org/eclipse/jkube/kit/common/util/LazyBuilder.java 100.00% <100.00%> (+100.00%) 4.00 <4.00> (+4.00)
...ava/org/eclipse/jkube/kit/common/util/XMLUtil.java 100.00% <100.00%> (ø) 9.00 <3.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c916f9...d63022d. Read the comment docs.

@manusa manusa added the WIP Work in Progress label Jun 22, 2020
@manusa manusa removed the WIP Work in Progress label Jun 22, 2020
@manusa manusa self-assigned this Jun 23, 2020
- pluginManagement pom.xml entries are now considered (both in profile and build)
- Granular control for fmp- f8- prefix replacements (only where applicable)
- Improved MigrateService IT suite, validate complete expected pom.xml
- "Mergeable" fragment directory (idempotent migrate goal)
+ Rafactored LazyBuilder

Signed-off-by: Marc Nuri <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jun 23, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

79.1% 79.1% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@rohanKanojia rohanKanojia merged commit fe0a1d8 into eclipse-jkube:master Jun 23, 2020
@manusa manusa deleted the fix/improve-migrate-mojo branch June 23, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants