PullRequest/issue#2528 #2937
Merged
PullRequest/issue#2528 #2937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anglerfishlyy
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #2937 (2024-04-18T12:44:51Z) ⚙️ JKube E2E Tests (8737647600)
|
pom.xml
Outdated
| @@ -517,6 +517,9 @@ | |||
| <dependencies> | |||
| <!-- JaCoCo runtime must be in classpath for offline mode --> | |||
| <dependency> | |||
| <groupId>com.fasterxml.jackson.core</groupId> | |||
| <artifactId>jackson-databind</artifactId> | |||
| <version>2.12.5</version> | |||
There was a problem hiding this comment.
How is this change related to #2528?
| @@ -230,6 +230,7 @@ void getAssembly_withAssembly_shouldReturnAssembly() { | |||
| @Test | |||
| void rawDeserialization() throws IOException { | |||
| // Given | |||
| //this line is already changed. | |||
There was a problem hiding this comment.
Please remove this comment
Suggested change
| //this line is already changed. |
|
@anglerfishlyy : Did you verify that project was building with your changes by running |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2937 +/- ##
=============================================
+ Coverage 59.36% 70.60% +11.23%
- Complexity 4586 5030 +444
=============================================
Files 500 488 -12
Lines 21211 19507 -1704
Branches 2830 2512 -318
=============================================
+ Hits 12591 13772 +1181
+ Misses 7370 4506 -2864
+ Partials 1250 1229 -21 ☔ View full report in Codecov by Sentry. |
anglerfishlyy
force-pushed
the
pr/issue2528
branch
from
3b04d22
to
79a5631
Compare
|
rohanKanojia
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #2528
It makes jsonmapper variable count in the code.
test, version modification, documentation, etc.)
Checklist