fix: helm push uses configured docker global and push registries instead of pull #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of pull The Docker/OCI registries used by the Helm Upload service were based on the configured global and pull registries. This was probably due to the fact that these registries were the only ones available from the JKubeConfiguration. Also because the name of the JKubeConfiguration field was misleading (see eclipse-jkube#3064). These changes replace the usage of the global and pull registries with the usage of the global and push registries. Signed-off-by: Marc Nuri <[email protected]>
Eclipse JKube CI ReportStarted new GH workflow run for #3067 (2024-05-17T06:53:02Z) ⚙️ JKube E2E Tests (9123296161)
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3067 +/- ##
=============================================
+ Coverage 59.36% 71.00% +11.63%
- Complexity 4586 5069 +483
=============================================
Files 500 488 -12
Lines 21211 19445 -1766
Branches 2830 2502 -328
=============================================
+ Hits 12591 13806 +1215
+ Misses 7370 4421 -2949
+ Partials 1250 1218 -32 ☔ View full report in Codecov by Sentry. |
...-plugin/plugin/src/test/java/org/eclipse/jkube/maven/plugin/mojo/build/HelmPushMojoTest.java
Show resolved
Hide resolved
rohanKanojia
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Docker/OCI registries used by the Helm Upload service were based on the configured global and pull registries. This was probably due to the fact that these registries were the only ones available from the JKubeConfiguration. Also because the name of the JKubeConfiguration field was misleading (see #3064).
These changes replace the usage of the global and pull registries with the usage of the global and push registries.
Type of change
test, version modification, documentation, etc.)
Checklist