-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #273: Enabling custom naming of the app label in deployment descriptor #325
Fix #273: Enabling custom naming of the app label in deployment descriptor #325
Conversation
Signed-off-by: Tue Dissing <[email protected]>
…ustomize the _app_ label. Signed-off-by: Tue Dissing <[email protected]>
Signed-off-by: Tue Dissing <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
============================================
+ Coverage 33.72% 33.74% +0.01%
Complexity 2169 2169
============================================
Files 364 364
Lines 18563 18564 +1
Branches 2741 2741
============================================
+ Hits 6261 6265 +4
+ Misses 11553 11550 -3
Partials 749 749
Continue to review full report at Codecov.
|
...icher/generic/src/test/java/org/eclipse/jkube/enricher/generic/MavenProjectEnricherTest.java
Outdated
Show resolved
Hide resolved
.../enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/ProjectLabelEnricher.java
Outdated
Show resolved
Hide resolved
.../enricher/generic/src/main/java/org/eclipse/jkube/enricher/generic/ProjectLabelEnricher.java
Outdated
Show resolved
Hide resolved
Renaming to APP/app Signed-off-by: Tue Dissing <[email protected]>
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/enricher/_jkube_project_label.adoc
Outdated
Show resolved
Hide resolved
Signed-off-by: Tue Dissing <[email protected]>
Kudos, SonarCloud Quality Gate passed! 0 Bugs 100.0% Coverage The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. |
LGTM, thx for contributing! ❤️ |
Description
Adding a new parameter for the
ProjectLabelEnricher
, calledcustomAppName
to make it possible to deploy the same application under the same namespace, but in different versions.This PR closes #273 .
Type of change
test, version modification, documentation, etc.)
Checklist