Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #273: Enabling custom naming of the app label in deployment descriptor #325

Merged
merged 5 commits into from
Jul 29, 2020

Conversation

TueDissingWork
Copy link
Contributor

@TueDissingWork TueDissingWork commented Jul 28, 2020

Description

Adding a new parameter for the ProjectLabelEnricher, called customAppName to make it possible to deploy the same application under the same namespace, but in different versions.
This PR closes #273 .

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • I have read the contributing guidelines
  • I signed-off my commit with a user that has signed the Eclipse Contributor Agreement
  • I Added CHANGELOG entry
  • I have implemented unit tests to cover my changes
  • I have updated the documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report (waiting for report to run)
  • I tested my code in Kubernetes (do not have a Kubernetes cluster available)
  • I tested my code in OpenShift

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #325 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #325      +/-   ##
============================================
+ Coverage     33.72%   33.74%   +0.01%     
  Complexity     2169     2169              
============================================
  Files           364      364              
  Lines         18563    18564       +1     
  Branches       2741     2741              
============================================
+ Hits           6261     6265       +4     
+ Misses        11553    11550       -3     
  Partials        749      749              
Impacted Files Coverage Δ Complexity Δ
...e/jkube/enricher/generic/ProjectLabelEnricher.java 60.00% <100.00%> (+0.62%) 7.00 <0.00> (ø)
...e/jkube/kit/config/service/PortForwardService.java 62.74% <0.00%> (+2.94%) 9.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ac53f...70c0fc5. Read the comment docs.

@TueDissingWork TueDissingWork changed the title Updating documentation to include new feature. Fix #273: Enabling custom naming of _app_ label in deployment descriptor Jul 28, 2020
@TueDissingWork TueDissingWork marked this pull request as ready for review July 28, 2020 13:23
@TueDissingWork TueDissingWork changed the title Fix #273: Enabling custom naming of _app_ label in deployment descriptor Fix #273: Enabling custom naming of the app label in deployment descriptor Jul 28, 2020
@rohanKanojia rohanKanojia requested a review from manusa July 28, 2020 14:29
Renaming to APP/app

Signed-off-by: Tue Dissing <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa manusa merged commit c24963d into eclipse-jkube:master Jul 29, 2020
@manusa
Copy link
Member

manusa commented Jul 29, 2020

LGTM, thx for contributing! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't seem to override the use of project.artifactId as the application reference in the deployment descriptor
4 participants