Issue 3404 replace mockito with actual object in wildflyjarhealthcheckenrichertest #3416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivamChavan01
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #3416 (2024-10-10T05:11:46Z) ⚙️ JKube E2E Tests (11261508645)
|
|
Hi @rohanKanojia, I’ve replaced the parts you suggested, but I'm facing challenges with replacing some Mockito.when statements with actual objects. Could you please guide me on how to proceed with these changes? LIKE |
|
@ShivamChavan01 : You can convert an object to builder using context = context.toBuilder()
.processorConfig(c)
.build();and similarly second pair of mocks can be converted like this: context = context.toBuilder()
.project(project.toBuilder()
.plugins(lst)
.build())
.processorConfig(c)
.build();Could you please test these if they're working? |
rohanKanojia
reviewed
Oct 3, 2024
| .returns(initialDelay, Probe::getInitialDelaySeconds) | ||
| .returns(failureThreshold, Probe::getFailureThreshold) | ||
| .returns(successThreshold, Probe::getSuccessThreshold) | ||
| .returns(periodSeconds, Probe::getPeriodSeconds); |
There was a problem hiding this comment.
Could you please revert these formatting changes?
There was a problem hiding this comment.
- Yeah I was formatting the code for some lines but it got effected I'll revert these changes
…heckEnricherTest class
This was referenced Oct 3, 2024
|
@ShivamChavan01 : Build seems to be failing: Could you please check these failures? |
…ith-actual-object-in-wildflyjarhealthcheckenrichertest
…actual-object-in-wildflyjarhealthcheckenrichertest' into issue-3404-replace-mockito-with-actual-object-in-wildflyjarhealthcheckenrichertest # Conflicts: # jkube-kit/jkube-kit-openliberty/src/test/java/org/eclipse/jkube/openliberty/OpenLibertyUtilsTest.java
|
Hey @rohanKanojia im getting these errors because of these lines in |
|
@ShivamChavan01 : Do you have installed Lombok plugin in your IntelliJ? |
I had previously installed the Lombok plugin, but since then, I've uninstalled it and reinstalled it. Unfortunately, I'm still encountering issues, and it hasn't resolved the problem. |
rohanKanojia
reviewed
Oct 7, 2024
| when(context.getProject()).thenReturn(project); | ||
| when(context.getConfiguration()).thenReturn(configBuilder.build()); | ||
| context = context.toBuilder() | ||
| .project(project.toBuilder() |
There was a problem hiding this comment.
Rather than creating a builder instance from member field project you should create it from context itself so that you don't lose changes done in context.getProject() after test setup
Suggested change
| .project(project.toBuilder() | |
| .project(context.getProject().toBuilder() |
rohanKanojia
reviewed
Oct 9, 2024
| when(context.getProject()).thenReturn(project); | ||
| project = JavaProject.builder().build(); | ||
| context = JKubeEnricherContext.builder() | ||
| .project(context.getProject()) |
There was a problem hiding this comment.
context is not initialized at this point.
Suggested change
| .project(context.getProject()) | |
| .project(project) |
|
rohanKanojia
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced Mockito.mock with actual object creation in WildflyJARHealthCheckEnricherTest
Fixes #3404
Type of change
test, version modification, documentation, etc.)
Checklist